feat: update the benchmark dataset and generator to add runner to the data id#7498
Closed
joseph-isaacs wants to merge 5 commits intodevelopfrom
Closed
feat: update the benchmark dataset and generator to add runner to the data id#7498joseph-isaacs wants to merge 5 commits intodevelopfrom
joseph-isaacs wants to merge 5 commits intodevelopfrom
Conversation
Contributor
|
this requires rebasing, the script doesn't exist after #7466 |
…r-more Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk> # Conflicts: # .github/scripts/run-sql-bench.sh # .github/workflows/sql-benchmarks.yml # vortex-bench/Cargo.toml # vortex-bench/src/runner.rs
github-actions
Bot
removed
the
action/benchmark-sql
Contributor
|
If benchmarks pass, lets merge it |
Contributor
Polar Signals Profiling ResultsLatest Run
Previous Runs (1)
Powered by Polar Signals Cloud |
Contributor
Benchmarks: PolarSignals ProfilingVortex (geomean): no vortex data datafusion / vortex-file-compressed (no group data, 0↑ 0↓)
|
Contributor
File Sizes: PolarSignals ProfilingFile Size Changes (1 files changed, +0.0% overall, 1↑ 0↓)
Totals:
|
Contributor
Benchmarks: TPC-H SF=1 on NVMEVortex (geomean): no vortex data datafusion / vortex-file-compressed (no group data, 0↑ 0↓)
datafusion / vortex-compact (no group data, 0↑ 0↓)
datafusion / parquet (no group data, 0↑ 0↓)
datafusion / arrow (no group data, 0↑ 0↓)
duckdb / vortex-file-compressed (no group data, 0↑ 0↓)
duckdb / vortex-compact (no group data, 0↑ 0↓)
duckdb / parquet (no group data, 0↑ 0↓)
duckdb / duckdb (no group data, 0↑ 0↓)
|
Contributor
File Sizes: TPC-H SF=1 on NVMEFile Size Changes (18 files changed, +0.0% overall, 18↑ 0↓)
Totals:
|
Contributor
Benchmarks: FineWeb NVMeVortex (geomean): no vortex data datafusion / vortex-file-compressed (no group data, 0↑ 0↓)
datafusion / vortex-compact (no group data, 0↑ 0↓)
datafusion / parquet (no group data, 0↑ 0↓)
duckdb / vortex-file-compressed (no group data, 0↑ 0↓)
duckdb / vortex-compact (no group data, 0↑ 0↓)
duckdb / parquet (no group data, 0↑ 0↓)
|
Contributor
File Sizes: FineWeb NVMeFile Size Changes (2 files changed, +0.0% overall, 2↑ 0↓)
Totals:
|
Contributor
|
@joseph-isaacs this breaks the baseline |
AdamGS
requested changes
Apr 22, 2026
Contributor
AdamGS
left a comment
AdamGS
left a comment
There was a problem hiding this comment.
This shouldn't invalidate all the history, either migrate it somehow or handle it during processing
Contributor
Benchmarks: TPC-DS SF=1 on NVMEVortex (geomean): no vortex data datafusion / vortex-file-compressed (no group data, 0↑ 0↓)
datafusion / vortex-compact (no group data, 0↑ 0↓)
datafusion / parquet (no group data, 0↑ 0↓)
duckdb / vortex-file-compressed (no group data, 0↑ 0↓)
duckdb / vortex-compact (no group data, 0↑ 0↓)
duckdb / parquet (no group data, 0↑ 0↓)
duckdb / duckdb (no group data, 0↑ 0↓)
|
Contributor
File Sizes: TPC-DS SF=1 on NVMEFile Size Changes (48 files changed, +0.0% overall, 48↑ 0↓)
Totals:
|
Contributor
Benchmarks: FineWeb S3Vortex (geomean): no vortex data datafusion / vortex-file-compressed (no group data, 0↑ 0↓)
datafusion / vortex-compact (no group data, 0↑ 0↓)
datafusion / parquet (no group data, 0↑ 0↓)
duckdb / vortex-file-compressed (no group data, 0↑ 0↓)
duckdb / vortex-compact (no group data, 0↑ 0↓)
duckdb / parquet (no group data, 0↑ 0↓)
|
Contributor
Benchmarks: TPC-H SF=10 on NVMEVortex (geomean): no vortex data datafusion / vortex-file-compressed (no group data, 0↑ 0↓)
datafusion / vortex-compact (no group data, 0↑ 0↓)
datafusion / parquet (no group data, 0↑ 0↓)
datafusion / arrow (no group data, 0↑ 0↓)
duckdb / vortex-file-compressed (no group data, 0↑ 0↓)
duckdb / vortex-compact (no group data, 0↑ 0↓)
duckdb / parquet (no group data, 0↑ 0↓)
duckdb / duckdb (no group data, 0↑ 0↓)
|
Contributor
File Sizes: TPC-H SF=10 on NVMEFile Size Changes (48 files changed, +0.0% overall, 48↑ 0↓)
Totals:
|
Contributor
Benchmarks: Statistical and Population GeneticsVortex (geomean): no vortex data duckdb / vortex-file-compressed (no group data, 0↑ 0↓)
duckdb / vortex-compact (no group data, 0↑ 0↓)
duckdb / parquet (no group data, 0↑ 0↓)
|
Contributor
File Sizes: Statistical and Population GeneticsFile Size Changes (2 files changed, +0.0% overall, 2↑ 0↓)
Totals:
|
Contributor
Benchmarks: TPC-H SF=1 on S3Vortex (geomean): no vortex data datafusion / vortex-file-compressed (no group data, 0↑ 0↓)
datafusion / vortex-compact (no group data, 0↑ 0↓)
datafusion / parquet (no group data, 0↑ 0↓)
duckdb / vortex-file-compressed (no group data, 0↑ 0↓)
duckdb / vortex-compact (no group data, 0↑ 0↓)
duckdb / parquet (no group data, 0↑ 0↓)
|
Contributor
🚨🚨🚨❌❌❌ SQL BENCHMARK FAILED ❌❌❌🚨🚨🚨Benchmark |
Contributor
Benchmarks: TPC-H SF=10 on S3Vortex (geomean): no vortex data datafusion / vortex-file-compressed (no group data, 0↑ 0↓)
datafusion / vortex-compact (no group data, 0↑ 0↓)
datafusion / parquet (no group data, 0↑ 0↓)
duckdb / vortex-file-compressed (no group data, 0↑ 0↓)
duckdb / vortex-compact (no group data, 0↑ 0↓)
duckdb / parquet (no group data, 0↑ 0↓)
|
Contributor
Author
|
I should have mentioned that I would migrate the data manually |
AdamGS
approved these changes
Apr 24, 2026
Contributor
AdamGS
left a comment
AdamGS
left a comment
There was a problem hiding this comment.
we can move the runner info into QueryMeasurement, just makes it easier to process later
joseph-isaacs
added
the
do not merge
Contributor
|
superseded by #7622 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
e.g.
tpch/sf_1/q01/ec2_c6id.8xlarge/datafusion:vortex-file-compressedThere is a local migration script.