Conversation
Merging this PR will degrade performance by 18.79%
Performance Changes
Comparing Footnotes
|
dacda20 to
a3048ea
Compare
| /// The input `fsl` must contain non-nullable, unit-norm vectors (already L2-normalized). Null | ||
| /// vectors are not supported and must be zeroed out before reaching this function. The rotation | ||
| /// and centroid lookup happen in f32. | ||
| fn turboquant_quantize_core( | ||
| fsl: &FixedSizeListArray, | ||
| seed: u64, | ||
| bit_width: u8, | ||
| num_rounds: u8, | ||
| ctx: &mut ExecutionCtx, | ||
| ) -> VortexResult<QuantizationResult> { |
There was a problem hiding this comment.
This is just moved down
| // TODO(connor): FIX THIS!!! | ||
| fn scheme_name(&self) -> &'static str { | ||
| "vortex.tensor.UNSTABLE.l2_denorm" | ||
| "vortex.tensor.l2_denorm" |
There was a problem hiding this comment.
I forgot that this is a completely separate label than the array IDs, and this is confined to just ID equality checking in the compressor
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
771fe03 to
d7f386c
Compare
Summary
Tracking issue: #7297
Given our fast velocity on this crate, quite a few things slipped through the cracks.
This change cleans up the
vortex-tensorcrate by clearly defining the abstraction points, fixing a few bugs (the only real bug was a TensorDisplaybug), cleaning up some TODOs, and generally raising the quality.API Changes
The only relevant change is new helper functions
Testing
Just fixed up existing tests.