Skip to content

deprecate: execute_mask over to_mask#7574

Merged
joseph-isaacs merged 2 commits intodevelopfrom
ji/fixup-more
Apr 20, 2026
Merged

deprecate: execute_mask over to_mask#7574
joseph-isaacs merged 2 commits intodevelopfrom
ji/fixup-more

Conversation

@joseph-isaacs
Copy link
Copy Markdown
Contributor

deprecate to mask to allow execute_mask to take a context

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
@joseph-isaacs joseph-isaacs added the changelog/deprecation A change that introduces a series of API deprecations label Apr 20, 2026
Signed-off-by: Joe Isaacs <joe@spiraldb.com>

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 20, 2026

Merging this PR will improve performance by 32.82%

⚡ 14 improved benchmarks
✅ 1149 untouched benchmarks
⏩ 1462 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation new_alp_prim_test_between[f64, 32768] 236.8 µs 193.5 µs +22.43%
Simulation old_alp_prim_test_between[f32, 32768] 271.3 µs 241.8 µs +12.17%
Simulation old_alp_prim_test_between[f64, 16384] 230 µs 207 µs +11.11%
Simulation old_bp_prim_test_between[i32, 32768] 249.3 µs 220 µs +13.33%
Simulation old_bp_prim_test_between[i64, 16384] 220.5 µs 189.6 µs +16.31%
Simulation old_alp_prim_test_between[f64, 32768] 331.8 µs 285.2 µs +16.35%
Simulation new_bp_prim_test_between[i64, 16384] 144.9 µs 115.9 µs +25.01%
Simulation new_bp_prim_test_between[i32, 32768] 169.9 µs 141.6 µs +20.03%
Simulation new_bp_prim_test_between[i32, 16384] 109.3 µs 95.4 µs +14.66%
Simulation new_bp_prim_test_between[i64, 32768] 236.5 µs 178.1 µs +32.82%
Simulation new_alp_prim_test_between[f32, 32768] 184.7 µs 156.2 µs +18.26%
Simulation new_alp_prim_test_between[f64, 16384] 148.9 µs 127.4 µs +16.87%
Simulation new_bp_prim_test_between[i16, 32768] 135.2 µs 121.5 µs +11.27%
Simulation old_bp_prim_test_between[i64, 32768] 327.6 µs 265.2 µs +23.54%

Comparing ji/fixup-more (2461d78) with develop (b213af1)

Open in CodSpeed

Footnotes

  1. 1462 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@joseph-isaacs joseph-isaacs merged commit be2a14b into develop Apr 20, 2026
60 checks passed
@joseph-isaacs joseph-isaacs deleted the ji/fixup-more branch April 20, 2026 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/deprecation A change that introduces a series of API deprecations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants