Skip to content

Allow bot approvals #7774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gatesn merged 1 commit into from
May 4, 2026
+8 −9
Merged

Allow bot approvals #7774

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions .github/workflows/approvals.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,21 +23,20 @@ jobs:
pull_number: pr.number,
});

// Count unique human approvals (latest review per user)
// Determine if PR author is a bot/GitHub Actions
const authorType = pr.user.type; // 'Bot' vs 'User'
const authorLogin = pr.user.login; // e.g. 'github-actions[bot]'
const isBot = authorType === 'Bot' || authorLogin.endsWith('[bot]');
const oneApprovalBotAuthors = new Set(['renovate[bot]']);

// Count unique approvals, including bot approvals.
const latestByUser = {};
for (const review of reviews.data) {
if (review.user.type === 'Bot') continue;
latestByUser[review.user.login] = review.state;
}
const approvalCount = Object.values(latestByUser)
.filter(state => state === 'APPROVED').length;

// Determine if PR author is a bot/GitHub Actions
const authorType = pr.user.type; // 'Bot' vs 'User'
const authorLogin = pr.user.login; // e.g. 'github-actions[bot]'
const isBot = authorType === 'Bot' || authorLogin.endsWith('[bot]');
const oneApprovalBotAuthors = new Set(['renovate[bot]']);

const required = isBot && !oneApprovalBotAuthors.has(authorLogin) ? 2 : 1;

console.log(`PR author: ${authorLogin} (${authorType}), isBot: ${isBot}`);
Expand All @@ -46,7 +45,7 @@ jobs:

if (isBot && (approvalCount < required)) {
core.setFailed(
`This PR needs ${required} human approval(s) but has ${approvalCount}. ` +
`This PR needs ${required} approval(s) but has ${approvalCount}. ` +
`(Author is ${isBot ? 'a bot' : 'human'})`
);
}
Loading