fix: make ExtDType metadata deserialization total over byte input#7782
Merged
fix: make ExtDType metadata deserialization total over byte input#7782
Conversation
Replace panicking index operations with proper bounds checks using vortex_ensure!, so malformed byte slices return VortexError instead of panicking: - date.rs: guard metadata[0] with !metadata.is_empty() check - time.rs: guard data[0] with !data.is_empty() check - timestamp.rs: improve existing data.len() >= 3 check to also validate data.len() >= 3 + tz_len before slicing timezone bytes Add regression tests for all three panic cases. Fixes #7773 Signed-off-by: vortex-claude <vortex-claude@users.noreply.github.com> Co-authored-by: Nicholas Gates <gatesn@users.noreply.github.com>
Contributor
|
Should consider adding some limited fuzzing passes to all of our serde to make sure it never panics |
Merging this PR will degrade performance by 24.98%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | varbinview_zip_fragmented_mask |
6.5 ms | 7.3 ms | -10.29% |
| ❌ | Simulation | varbinview_zip_block_mask |
2.9 ms | 3.7 ms | -21.64% |
| ❌ | Simulation | new_bp_prim_test_between[i64, 32768] |
177.3 µs | 236.3 µs | -24.98% |
Comparing claude/issue-7773-20260504-1600 (64e6493) with develop (44a6367)
Footnotes
-
138 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7773
Generated with Claude Code