Skip to content

tracing logger for duckdb#7892

Merged
myrrc merged 1 commit into
developfrom
myrrc/duckb-log
May 12, 2026
Merged

tracing logger for duckdb#7892
myrrc merged 1 commit into
developfrom
myrrc/duckb-log

Conversation

@myrrc
Copy link
Copy Markdown
Contributor

@myrrc myrrc commented May 12, 2026

  • Add stdout logger for Vortex in duckdb (we use it only for debugging anyway).
  • Move some log messages from debug to trace
  • Don't cast file_row_number to i64, use u64 as target column.
  • Fix dynamic filter printing

Resolves #6820

@myrrc myrrc requested a review from joseph-isaacs May 12, 2026 09:35
@myrrc myrrc added changelog/feature A new feature ext/duckdb Relates to the DuckDB integration labels May 12, 2026
@myrrc myrrc enabled auto-merge (squash) May 12, 2026 09:38
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 12, 2026

Merging this PR will degrade performance by 24.73%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

❌ 6 regressed benchmarks
✅ 1204 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation new_bp_prim_test_between[i16, 32768] 120.9 µs 134.9 µs -10.33%
Simulation new_bp_prim_test_between[i32, 16384] 95.3 µs 109.7 µs -13.07%
Simulation new_bp_prim_test_between[i32, 32768] 141.7 µs 170.5 µs -16.93%
Simulation new_bp_prim_test_between[i64, 32768] 178.6 µs 237.3 µs -24.73%
Simulation new_bp_prim_test_between[i64, 16384] 115.7 µs 145 µs -20.2%
Simulation new_alp_prim_test_between[f64, 16384] 127.6 µs 149.5 µs -14.66%

Comparing myrrc/duckb-log (02ca097) with develop (2ee2033)

Open in CodSpeed

Copy link
Copy Markdown
Contributor

@joseph-isaacs joseph-isaacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put this at the top level

Signed-off-by: Mikhail Kot <to@myrrc.dev>
@myrrc myrrc force-pushed the myrrc/duckb-log branch from 3ec9e96 to 02ca097 Compare May 12, 2026 10:06
@myrrc myrrc requested a review from joseph-isaacs May 12, 2026 10:06
@myrrc myrrc removed the request for review from joseph-isaacs May 12, 2026 14:14
@myrrc myrrc merged commit 3e93048 into develop May 12, 2026
65 of 66 checks passed
@myrrc myrrc deleted the myrrc/duckb-log branch May 12, 2026 14:14
Comment thread vortex-duckdb/src/lib.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/feature A new feature ext/duckdb Relates to the DuckDB integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DuckDB: set up tracing:: subscriber

3 participants