Skip to content

faster cast#7893

Closed
joseph-isaacs wants to merge 1 commit into
developfrom
ji/faster-cast
Closed

faster cast#7893
joseph-isaacs wants to merge 1 commit into
developfrom
ji/faster-cast

Conversation

@joseph-isaacs
Copy link
Copy Markdown
Contributor

Summary

Closes: #000

Testing

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 12, 2026

Merging this PR will degrade performance by 21.7%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚡ 24 improved benchmarks
❌ 3 regressed benchmarks
✅ 1183 untouched benchmarks
🆕 10 new benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation take_search[(0.005, 0.05)] 168.2 µs 131.8 µs +27.57%
Simulation take_search[(0.005, 0.1)] 320.1 µs 247.4 µs +29.41%
Simulation take_search[(0.005, 0.5)] 1.5 ms 1.2 ms +31.01%
Simulation take_search[(0.005, 1.0)] 3.1 ms 2.3 ms +31.24%
Simulation take_search[(0.01, 0.05)] 179.3 µs 142.9 µs +25.43%
Simulation take_search[(0.01, 0.1)] 341 µs 268.3 µs +27.12%
Simulation take_search[(0.01, 0.5)] 1.6 ms 1.3 ms +28.55%
Simulation take_search[(0.01, 1.0)] 3.3 ms 2.5 ms +28.76%
Simulation take_search[(0.1, 0.05)] 248.9 µs 212.6 µs +17.1%
Simulation take_search[(0.1, 0.1)] 458.5 µs 385.7 µs +18.87%
Simulation take_search[(0.1, 0.5)] 2.2 ms 1.8 ms +20.39%
Simulation take_search[(0.1, 1.0)] 4.3 ms 3.5 ms +20.62%
Simulation take_search_chunked[(0.005, 0.05)] 192.9 µs 162.1 µs +18.97%
Simulation take_search_chunked[(0.005, 0.1)] 368.9 µs 307.2 µs +20.08%
Simulation take_search_chunked[(0.005, 0.5)] 1.8 ms 1.5 ms +21.04%
Simulation take_search_chunked[(0.005, 1.0)] 3.5 ms 2.9 ms +21.18%
Simulation take_search_chunked[(0.01, 0.05)] 206 µs 175.2 µs +17.55%
Simulation take_search_chunked[(0.01, 0.1)] 393.7 µs 332 µs +18.59%
Simulation take_search_chunked[(0.01, 0.5)] 1.9 ms 1.6 ms +19.46%
Simulation take_search_chunked[(0.01, 1.0)] 3.8 ms 3.2 ms +19.58%
... ... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.


Comparing ji/faster-cast (afcef9e) with develop (2ee2033)

Open in CodSpeed

@robert3005
Copy link
Copy Markdown
Contributor

in codspeed those two look the same. I wonder if this is because of callgrind

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants