Add DType::Union variant carrying just Nullability#7901
Merged
Conversation
3938630 to
4d92593
Compare
8 tasks
Merging this PR will degrade performance by 21.7%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | varbinview_zip_block_mask |
2.9 ms | 3.7 ms | -21.7% |
| ❌ | Simulation | varbinview_zip_fragmented_mask |
6.2 ms | 6.9 ms | -11.29% |
Comparing ct/add-union-boilerplate (06f2495) with develop (c663fa9)
joseph-isaacs
approved these changes
May 12, 2026
55d296e to
ceeeaed
Compare
This is the first of two commits splitting the original Union work. It adds the
`Union(Nullability)` enum variant, plumbs it through all existing match arms
with `todo!("TODO(connor)[Union]: unimplemented")`, and reserves slot 12 in the
flatbuffer and protobuf wire schemas. A follow-up commit will replace
`Union(Nullability)` with `Union(UnionVariants, Nullability)` and fill in the
serde paths.
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
4d92593 to
06f2495
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tracking issue: #7882
Adds the
Union(Nullability)enum variant, plumbs it through all existing match arms withtodo!("TODO(connor)[Union]: unimplemented"), and reserves slot 12 in the flatbuffer and protobuf wire schemas.A follow-up PR will replace
Union(Nullability)withUnion(UnionVariants, Nullability)and fill in the serde paths.Note that this PR doesn't have any implementation logic, it is just boilerplate.
API Changes
Adds a new
DType::Unionvariant.Testing
Nothing to test.