Skip to content

Add DType::Union variant carrying just Nullability#7901

Merged
connortsui20 merged 1 commit into
developfrom
ct/add-union-boilerplate
May 12, 2026
Merged

Add DType::Union variant carrying just Nullability#7901
connortsui20 merged 1 commit into
developfrom
ct/add-union-boilerplate

Conversation

@connortsui20
Copy link
Copy Markdown
Contributor

@connortsui20 connortsui20 commented May 12, 2026

Summary

Tracking issue: #7882

Adds the Union(Nullability) enum variant, plumbs it through all existing match arms with todo!("TODO(connor)[Union]: unimplemented"), and reserves slot 12 in the flatbuffer and protobuf wire schemas.

A follow-up PR will replace Union(Nullability) with Union(UnionVariants, Nullability) and fill in the serde paths.

Note that this PR doesn't have any implementation logic, it is just boilerplate.

API Changes

Adds a new DType::Union variant.

Testing

Nothing to test.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 12, 2026

Merging this PR will degrade performance by 21.7%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

❌ 2 regressed benchmarks
✅ 1208 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation varbinview_zip_block_mask 2.9 ms 3.7 ms -21.7%
Simulation varbinview_zip_fragmented_mask 6.2 ms 6.9 ms -11.29%

Comparing ct/add-union-boilerplate (06f2495) with develop (c663fa9)

Open in CodSpeed

Base automatically changed from ct/fb-update to develop May 12, 2026 17:07
This is the first of two commits splitting the original Union work. It adds the
`Union(Nullability)` enum variant, plumbs it through all existing match arms
with `todo!("TODO(connor)[Union]: unimplemented")`, and reserves slot 12 in the
flatbuffer and protobuf wire schemas. A follow-up commit will replace
`Union(Nullability)` with `Union(UnionVariants, Nullability)` and fill in the
serde paths.

Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
@connortsui20 connortsui20 force-pushed the ct/add-union-boilerplate branch from 4d92593 to 06f2495 Compare May 12, 2026 18:22
@connortsui20 connortsui20 enabled auto-merge (squash) May 12, 2026 18:22
@connortsui20 connortsui20 merged commit e56c80d into develop May 12, 2026
61 checks passed
@connortsui20 connortsui20 deleted the ct/add-union-boilerplate branch May 12, 2026 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/feature A new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants