Skip to content

Use async_fs file for java and python writes to avoid object_store buffering on local disks#7920

Merged
robert3005 merged 1 commit into
developfrom
rk/asyncfscreate
May 14, 2026
Merged

Use async_fs file for java and python writes to avoid object_store buffering on local disks#7920
robert3005 merged 1 commit into
developfrom
rk/asyncfscreate

Conversation

@robert3005
Copy link
Copy Markdown
Contributor

Object store writes are tuned for multipart uploads, it's simpler to use std
file for local writes

Signed-off-by: Robert Kruszewski <github@robertk.io>
@robert3005
Copy link
Copy Markdown
Contributor Author

This is recreation of #7904 with small addition of having python also go through local file for writes. This already happens in C/C++ and is not necessary in rust since we don't expose api to write to a path so the user has to resolve the path to file handle

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 14, 2026

Merging this PR will improve performance by 20.27%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 6 improved benchmarks
✅ 1210 untouched benchmarks
⏩ 24 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation new_bp_prim_test_between[i16, 32768] 134.1 µs 120.2 µs +11.57%
Simulation new_bp_prim_test_between[i32, 32768] 169.9 µs 141.1 µs +20.44%
Simulation new_bp_prim_test_between[i32, 16384] 109.1 µs 94.8 µs +15.11%
Simulation new_bp_prim_test_between[i64, 16384] 144.4 µs 115.1 µs +25.43%
Simulation new_bp_prim_test_between[i64, 32768] 236.7 µs 178 µs +32.96%
Simulation new_alp_prim_test_between[f64, 16384] 148.8 µs 126.9 µs +17.29%

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.


Comparing rk/asyncfscreate (214dfb1) with develop (7349cd6)

Open in CodSpeed

Footnotes

  1. 24 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@robert3005 robert3005 added the changelog/chore A trivial change label May 14, 2026
@robert3005 robert3005 merged commit 1f6fb0a into develop May 14, 2026
70 of 71 checks passed
@robert3005 robert3005 deleted the rk/asyncfscreate branch May 14, 2026 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants