Skip to content

2: Add NullCount aggregate function#7929

Merged
gatesn merged 1 commit into
ngates/aggregatefn-stat-bridge-cleanupfrom
ngates/stats-7707/null-count-stat-wrappers
May 14, 2026
Merged

2: Add NullCount aggregate function#7929
gatesn merged 1 commit into
ngates/aggregatefn-stat-bridge-cleanupfrom
ngates/stats-7707/null-count-stat-wrappers

Conversation

@gatesn
Copy link
Copy Markdown
Contributor

@gatesn gatesn commented May 14, 2026

Part of #7707.

Base: #7931
Next: #7930

Summary

  • Add a NullCount aggregate wrapper and register it in the aggregate function session.
  • Bridge Stat::NullCount through the Stat aggregate-function mapping introduced by Centralize aggregate stat bridge #7931.
  • Add stats expression constructors used by the current pruning/stat expression path.

Checks

  • cargo test -p vortex-array null_count
  • cargo test -p vortex-array stat_expr
  • ./scripts/public-api.sh
  • cargo clippy --all-targets --all-features

@gatesn gatesn changed the title Add null count stat aggregate wrappers 2: Add null count stat aggregate wrappers May 14, 2026
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 14, 2026

Merging this PR will degrade performance by 16.64%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

❌ 6 regressed benchmarks
✅ 1210 untouched benchmarks
⏩ 24 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation new_bp_prim_test_between[i16, 32768] 121 µs 134.7 µs -10.15%
Simulation new_bp_prim_test_between[i32, 16384] 95.3 µs 109.5 µs -12.94%
Simulation new_bp_prim_test_between[i64, 32768] 178.8 µs 237.2 µs -24.6%
Simulation new_bp_prim_test_between[i32, 32768] 141.7 µs 170.4 µs -16.84%
Simulation new_bp_prim_test_between[i64, 16384] 115.9 µs 144.9 µs -19.98%
Simulation new_alp_prim_test_between[f64, 16384] 127.7 µs 149.3 µs -14.51%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing ngates/stats-7707/null-count-stat-wrappers (85a04e0) with ngates/aggregatefn-stat-bridge-cleanup (7b76045)

Open in CodSpeed

Footnotes

  1. 24 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@gatesn gatesn force-pushed the ngates/stats-7707/null-count-stat-wrappers branch from 02d39d4 to 4896ec4 Compare May 14, 2026 19:54
@gatesn gatesn force-pushed the ngates/stats-7707/chunked-stat-execute-parent branch from 07bfcdc to 261cbe4 Compare May 14, 2026 19:54
@gatesn gatesn added the changelog/chore A trivial change label May 14, 2026 — with ChatGPT Codex Connector
@gatesn gatesn force-pushed the ngates/stats-7707/null-count-stat-wrappers branch from 4896ec4 to 75ba3eb Compare May 14, 2026 20:27
@gatesn gatesn force-pushed the ngates/stats-7707/chunked-stat-execute-parent branch from 261cbe4 to 0dce6a1 Compare May 14, 2026 20:27
Base automatically changed from ngates/stats-7707/chunked-stat-execute-parent to develop May 14, 2026 20:37
gatesn added a commit that referenced this pull request May 14, 2026
Part of #7707.

Stack: 1/3

Base: `develop`
Next: #7929

## Summary

- Remove the explicit chunked-array special case from `StatFn::execute`.
- Rely on the existing chunked scalar-function pushdown path to preserve
per-chunk stat results.
- Keep the existing chunked stats regression test covering the behavior.

## Checks

- `cargo test -p vortex-array stat_expr_reads_cached_sum_per_chunk`

Signed-off-by: "Nicholas Gates" <nick@nickgates.com>
@gatesn gatesn force-pushed the ngates/stats-7707/null-count-stat-wrappers branch from 75ba3eb to 2839387 Compare May 14, 2026 21:00
Signed-off-by: Nicholas Gates <nick@nickgates.com>
@gatesn gatesn force-pushed the ngates/stats-7707/null-count-stat-wrappers branch from 2839387 to 85a04e0 Compare May 14, 2026 21:05
@gatesn gatesn changed the base branch from develop to ngates/aggregatefn-stat-bridge-cleanup May 14, 2026 21:05
@gatesn gatesn changed the title 2: Add null count stat aggregate wrappers 2: Add NullCount aggregate function May 14, 2026
@gatesn gatesn marked this pull request as ready for review May 14, 2026 21:11
@gatesn gatesn merged commit 19e7315 into ngates/aggregatefn-stat-bridge-cleanup May 14, 2026
61 checks passed
@gatesn gatesn deleted the ngates/stats-7707/null-count-stat-wrappers branch May 14, 2026 21:11
gatesn added a commit that referenced this pull request May 14, 2026
This reverts commit 19e7315.

Signed-off-by: Nicholas Gates <nick@nickgates.com>
gatesn added a commit that referenced this pull request May 14, 2026
Part of #7707.

Replacement for #7929 after the accidental merge was reverted before
#7931 landed.

Base: `develop`
Next: #7930

## Summary

- Add a `NullCount` aggregate wrapper and register it in the aggregate
function session.
- Bridge `Stat::NullCount` through the `Stat` aggregate-function mapping
introduced by #7931.
- Add stats expression constructors used by the current pruning/stat
expression path.

## Checks

- `cargo test -p vortex-array null_count`
- `cargo test -p vortex-array stat_expr`
- `./scripts/public-api.sh`
- `cargo clippy --all-targets --all-features`

Signed-off-by: Nicholas Gates <nick@nickgates.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant