Centralize aggregate stat bridge#7931
Merged
Merged
Conversation
Merging this PR will not alter performance
|
gatesn
force-pushed
the
ngates/aggregatefn-stat-bridge-cleanup
branch
from
28050c0 to
c86068c
Compare
gatesn
force-pushed
the
ngates/aggregatefn-stat-bridge-cleanup
branch
from
c86068c to
254f53d
Compare
auto-merge was automatically disabled
May 14, 2026 20:36
Pull request was converted to draft
gatesn
force-pushed
the
ngates/aggregatefn-stat-bridge-cleanup
branch
from
254f53d to
952ca3d
Compare
Signed-off-by: Nicholas Gates <nick@nickgates.com>
gatesn
force-pushed
the
ngates/aggregatefn-stat-bridge-cleanup
branch
from
952ca3d to
7b76045
Compare
This was referenced May 14, 2026
Part of #7707. Base: #7931 Next: #7930 ## Summary - Add a `NullCount` aggregate wrapper and register it in the aggregate function session. - Bridge `Stat::NullCount` through the `Stat` aggregate-function mapping introduced by #7931. - Add stats expression constructors used by the current pruning/stat expression path. ## Checks - `cargo test -p vortex-array null_count` - `cargo test -p vortex-array stat_expr` - `./scripts/public-api.sh` - `cargo clippy --all-targets --all-features` Signed-off-by: Nicholas Gates <nick@nickgates.com>
This reverts commit 19e7315. Signed-off-by: Nicholas Gates <nick@nickgates.com>
robert3005
approved these changes
May 14, 2026
gatesn
added a commit
that referenced
this pull request
May 14, 2026
Part of #7707. Replacement for #7929 after the accidental merge was reverted before #7931 landed. Base: `develop` Next: #7930 ## Summary - Add a `NullCount` aggregate wrapper and register it in the aggregate function session. - Bridge `Stat::NullCount` through the `Stat` aggregate-function mapping introduced by #7931. - Add stats expression constructors used by the current pruning/stat expression path. ## Checks - `cargo test -p vortex-array null_count` - `cargo test -p vortex-array stat_expr` - `./scripts/public-api.sh` - `cargo clippy --all-targets --all-features` Signed-off-by: Nicholas Gates <nick@nickgates.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AggregateFnVTable::try_partial_from_statswith aStat-owned bridge:Stat::aggregate_fnandStat::from_aggregate_fn.Accumulator::accumulateso accumulator-based aggregate execution still skips kernel dispatch and decode when a matching exact stat exists.sum,nan_count, anduncompressed_size_in_bytesso cached stats also skip accumulator construction.vortex-array/src/stats/legacy.rsnow that the mapping lives onStat.Checks
cargo test -p vortex-array stat_expr./scripts/public-api.shcargo clippy --all-targets --all-features