Add NullCount aggregate function#7933
Conversation
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Merging this PR will degrade performance by 17.06%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | new_bp_prim_test_between[i32, 32768] |
141.2 µs | 170.4 µs | -17.14% |
| ❌ | Simulation | new_bp_prim_test_between[i64, 16384] |
115.2 µs | 144.9 µs | -20.48% |
| ❌ | Simulation | new_bp_prim_test_between[i64, 32768] |
178.1 µs | 237.2 µs | -24.9% |
| ❌ | Simulation | new_alp_prim_test_between[f64, 16384] |
126.9 µs | 149.3 µs | -15.04% |
| ❌ | Simulation | new_bp_prim_test_between[i16, 32768] |
120.4 µs | 134.7 µs | -10.57% |
| ❌ | Simulation | new_bp_prim_test_between[i32, 16384] |
94.8 µs | 109.5 µs | -13.4% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing ngates/stats-7707/null-count-stat-wrappers-v2 (3fc3da5) with develop (8c5a0f1)2
Footnotes
-
24 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
-
No successful run was found on
develop(a514cef) during the generation of this report, so 8c5a0f1 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩
Part of #7707.
Replacement for #7929 after the accidental merge was reverted before #7931 landed.
Base:
developNext: #7930
Summary
NullCountaggregate wrapper and register it in the aggregate function session.Stat::NullCountthrough theStataggregate-function mapping introduced by Centralize aggregate stat bridge #7931.Checks
cargo test -p vortex-array null_countcargo test -p vortex-array stat_expr./scripts/public-api.shcargo clippy --all-targets --all-features