Add built-in stats rewrite rules#7935
Open
gatesn wants to merge 2 commits into
Open
Conversation
988447b to
b22ebfe
Compare
dfce840 to
b08d3d5
Compare
b22ebfe to
c1e72a3
Compare
b08d3d5 to
410ff05
Compare
Merging this PR will improve performance by 12.35%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | Simulation | encode_varbin[(1000, 2)] |
168 µs | 148.2 µs | +13.36% |
| ⚡ | Simulation | encode_varbin[(1000, 32)] |
175 µs | 155.4 µs | +12.62% |
| ⚡ | Simulation | encode_varbin[(1000, 4)] |
168.9 µs | 149.4 µs | +13.06% |
| ⚡ | Simulation | encode_varbin[(1000, 8)] |
165.8 µs | 150.2 µs | +10.37% |
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing ngates/stats-7707/built-in-rewrite-rules (ad61595) with develop (1f6fb0a)1
Footnotes
5cdafee to
9700eec
Compare
c1e72a3 to
4f74bb3
Compare
9700eec to
bc790ff
Compare
4f74bb3 to
78f93f1
Compare
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
bc790ff to
ad61595
Compare
78f93f1 to
aa967fc
Compare
robert3005
approved these changes
May 15, 2026
aa967fc to
d963a44
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
StatFn::new_expr(...)all_nullandall_non_nullnull_count/row_count()rewrite rules so current stored stats continue to workTests
cargo +nightly fmt --allcargo test -p vortex-array stats::rewrite::builtins::tests::rewrites_nullcargo test -p vortex-array stats::rewritecargo clippy --all-targets --all-features