feat(vortex-geo): Arrow import/export for the native Point type#8374
Open
HarukiMoriarty wants to merge 1 commit into
Open
feat(vortex-geo): Arrow import/export for the native Point type#8374HarukiMoriarty wants to merge 1 commit into
HarukiMoriarty wants to merge 1 commit into
Conversation
Register ArrowImportVTable/ArrowExportVTable for the Point extension type, mapping geoarrow.point fields (separated coordinates) to and from vortex.geo.point with the CRS carried through. Interleaved coordinates are rejected at field import. The CRS metadata conversion is shared with the WKB vtables, and the coordinate storage dtype now has a canonical constructor inverse to coordinate_dimension. Signed-off-by: Nemo Yu <zyu379@wisc.edu>
Merging this PR will improve performance by 13.08%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | bitwise_not_vortex_buffer_mut[128] |
215.3 ns | 244.4 ns | -11.93% |
| ❌ | Simulation | chunked_varbinview_canonical_into[(100, 100)] |
273.3 µs | 309.3 µs | -11.65% |
| ⚡ | Simulation | take_10k_random |
254.5 µs | 196.8 µs | +29.34% |
| ⚡ | Simulation | patched_take_10k_contiguous_patches |
289.2 µs | 230.5 µs | +25.49% |
| ⚡ | Simulation | patched_take_10k_random |
301.2 µs | 242.4 µs | +24.23% |
| ⚡ | Simulation | take_10k_contiguous |
310.5 µs | 251.9 µs | +23.25% |
| ⚡ | Simulation | chunked_varbinview_canonical_into[(1000, 10)] |
197.9 µs | 161.8 µs | +22.28% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing nemo/geo-point-arrow (638d514) with nemo/geo-point (491f49f)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for import/export to Arrow for the
Pointextension type, as thegeoarrow.pointArrow extension with separated (struct) coordinates.Stacked on #8372.
Testing
Unit tests are added to exercise both code paths, plus a Vortex → Arrow → Vortex round-trip.