Skip to content

Ignore PyO3 rustsec#8381

Open
connortsui20 wants to merge 2 commits into
developfrom
ct/pyo3-rustsec
Open

Ignore PyO3 rustsec#8381
connortsui20 wants to merge 2 commits into
developfrom
ct/pyo3-rustsec

Conversation

@connortsui20

@connortsui20 connortsui20 commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Summary

Ignores the pyo3 rustsec because there are other dependencies that haven't upgraded yet.

Testing

N/A

Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
@connortsui20 connortsui20 requested review from a team and gatesn June 11, 2026 22:18
@connortsui20 connortsui20 added the changelog/fix A bug fix label Jun 11, 2026
@connortsui20 connortsui20 enabled auto-merge (squash) June 11, 2026 22:19

@gatesn gatesn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make this not a required check for branches, but still required before release

@connortsui20 connortsui20 changed the title Ignore rustsec Ignore PyO3 Rustsec Jun 11, 2026
@connortsui20 connortsui20 changed the title Ignore PyO3 Rustsec Ignore PyO3 rustsec Jun 11, 2026
@codspeed-hq

codspeed-hq Bot commented Jun 11, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 26.18%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚡ 5 improved benchmarks
✅ 1531 untouched benchmarks

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation chunked_bool_canonical_into[(1000, 10)] 35.5 µs 20.5 µs +72.93%
Simulation chunked_varbinview_canonical_into[(1000, 10)] 198.1 µs 161.9 µs +22.35%
Simulation chunked_varbinview_into_canonical[(1000, 10)] 213.5 µs 177.4 µs +20.39%
Simulation bitwise_not_vortex_buffer_mut[128] 244.4 ns 215.3 ns +13.55%
Simulation bitwise_not_vortex_buffer_mut[1024] 304.7 ns 275.6 ns +10.58%

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.


Comparing ct/pyo3-rustsec (258839b) with develop (8acef3a)

Open in CodSpeed

@robert3005

Copy link
Copy Markdown
Contributor

These aren't required checks already

@AdamGS AdamGS left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine, as far as I can tell we don't use those code paths, and this is a relatively minor dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/fix A bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants