Skip to content

Run RustSec before publish#8382

Open
gatesn wants to merge 1 commit into
developfrom
ngates/rustsec
Open

Run RustSec before publish#8382
gatesn wants to merge 1 commit into
developfrom
ngates/rustsec

Conversation

@gatesn

@gatesn gatesn commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: Nicholas Gates <nick@nickgates.com>
@gatesn gatesn requested review from a team and robert3005 June 11, 2026 22:28
@gatesn gatesn added the changelog/chore A trivial change label Jun 11, 2026

@robert3005 robert3005 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do you retrigger this on the same commit? I don't like that you will have permanently broken release if you don't check this. Would prefer a release that we might need to yank

Comment thread .github/workflows/ci.yml
Comment on lines +397 to +398
# Prevent sudden announcement of a new advisory from failing CI or blocking PR merges.
continue-on-error: ${{ matrix.checks == 'advisories' }}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want to just delete this and only check on release?

@robert3005

Copy link
Copy Markdown
Contributor

I think this check should run on every pr and before cutting release you have to check the status of it on develop. The ideal solution is to have a release bot that would check this and only tag if the check passes no tag and then check

@codspeed-hq

codspeed-hq Bot commented Jun 11, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 21.6%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚡ 7 improved benchmarks
✅ 1519 untouched benchmarks
⏩ 10 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation chunked_bool_canonical_into[(1000, 10)] 35.5 µs 20.5 µs +72.93%
Simulation chunked_varbinview_canonical_into[(1000, 10)] 198.1 µs 161.9 µs +22.35%
Simulation chunked_varbinview_into_canonical[(1000, 10)] 213.5 µs 177.4 µs +20.39%
Simulation encode_varbin[(1000, 4)] 159.7 µs 142.5 µs +12.1%
Simulation encode_varbin[(1000, 8)] 160.4 µs 143.2 µs +12%
Simulation encode_varbin[(1000, 32)] 164.9 µs 148.1 µs +11.34%
Simulation encode_varbin[(1000, 512)] 219.7 µs 199 µs +10.42%

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.


Comparing ngates/rustsec (0f5b1ce) with develop (8475910)

Open in CodSpeed

Footnotes

  1. 10 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants