Run RustSec before publish#8382
Conversation
Signed-off-by: Nicholas Gates <nick@nickgates.com>
robert3005
left a comment
There was a problem hiding this comment.
How do you retrigger this on the same commit? I don't like that you will have permanently broken release if you don't check this. Would prefer a release that we might need to yank
| # Prevent sudden announcement of a new advisory from failing CI or blocking PR merges. | ||
| continue-on-error: ${{ matrix.checks == 'advisories' }} |
There was a problem hiding this comment.
do we want to just delete this and only check on release?
|
I think this check should run on every pr and before cutting release you have to check the status of it on develop. The ideal solution is to have a release bot that would check this and only tag if the check passes no tag and then check |
Merging this PR will improve performance by 21.6%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | Simulation | chunked_bool_canonical_into[(1000, 10)] |
35.5 µs | 20.5 µs | +72.93% |
| ⚡ | Simulation | chunked_varbinview_canonical_into[(1000, 10)] |
198.1 µs | 161.9 µs | +22.35% |
| ⚡ | Simulation | chunked_varbinview_into_canonical[(1000, 10)] |
213.5 µs | 177.4 µs | +20.39% |
| ⚡ | Simulation | encode_varbin[(1000, 4)] |
159.7 µs | 142.5 µs | +12.1% |
| ⚡ | Simulation | encode_varbin[(1000, 8)] |
160.4 µs | 143.2 µs | +12% |
| ⚡ | Simulation | encode_varbin[(1000, 32)] |
164.9 µs | 148.1 µs | +11.34% |
| ⚡ | Simulation | encode_varbin[(1000, 512)] |
219.7 µs | 199 µs | +10.42% |
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing ngates/rustsec (0f5b1ce) with develop (8475910)
Footnotes
-
10 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
No description provided.