Skip to content

vortex-tui: query tab should work for non-*.vortex files#8473

Merged
a10y merged 1 commit into
developfrom
aduffy/fix-df-crawl
Jun 17, 2026
Merged

vortex-tui: query tab should work for non-*.vortex files#8473
a10y merged 1 commit into
developfrom
aduffy/fix-df-crawl

Conversation

@a10y

@a10y a10y commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Summary

Because of how ListingTable works, previously if we had a non-*.vortex file (for example, a file downloaded via a presigned URL from S3) it would open and otherwise be perfectly usable with the TUI, except the query tab would fail to list it, for two reasons

  1. HEAD only works for canonical paths
  2. There was a filter for *.vortex files being applied by our format

By overriding the format file filter and canonicalizing the path, we can force ListingTable to work with the single file we pass as the argument to vx browse

Testing

Tested with a local file without a .vortex file extension and confirmed that before could not query, now I can.

@a10y a10y requested a review from a team June 17, 2026 14:37
@a10y a10y added the changelog/fix A bug fix label Jun 17, 2026
@codspeed-hq

codspeed-hq Bot commented Jun 17, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 33.15%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

❌ 14 regressed benchmarks
✅ 1518 untouched benchmarks
⏩ 60 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation slice_empty_vortex 368.3 ns 2,686.9 ns -86.29%
Simulation chunked_bool_canonical_into[(1000, 10)] 20.3 µs 35.7 µs -43.24%
Simulation slice_vortex_buffer[1024] 871.4 ns 1,305.8 ns -33.27%
Simulation slice_vortex_buffer[16384] 871.4 ns 1,305.8 ns -33.27%
Simulation slice_vortex_buffer[2048] 871.4 ns 1,305.8 ns -33.27%
Simulation slice_vortex_buffer[128] 871.4 ns 1,305.8 ns -33.27%
Simulation slice_vortex_buffer[65536] 871.4 ns 1,305.8 ns -33.27%
Simulation chunked_varbinview_canonical_into[(1000, 10)] 162.2 µs 198.1 µs -18.09%
Simulation chunked_varbinview_into_canonical[(1000, 10)] 177.7 µs 214 µs -16.98%
Simulation search_index_below_min_chunked 1.3 ms 1.5 ms -13.61%
Simulation search_index_mixed_out_of_range_chunked 1.3 ms 1.5 ms -13.3%
Simulation count_i32_clustered_nulls 47 µs 53.9 µs -12.83%
Simulation search_index_full_range_random_chunked 1.4 ms 1.6 ms -12.06%
Simulation chunked_varbinview_canonical_into[(100, 100)] 273.2 µs 308.8 µs -11.53%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing aduffy/fix-df-crawl (b374ab3) with develop (85aad72)2

Open in CodSpeed

Footnotes

  1. 60 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on develop (0ed06b3) during the generation of this report, so 85aad72 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Because of how ListingTable works, previously if we had a non-*.vortex
file (for example, a file downloaded via a presigned URL from S3) it
would open and otherwise be perfectly usable with the TUI, except the
query tab would fail to list it, for two reasons

1. HEAD only works for canonical paths
2. There was a filter for *.vortex files being applied by our format

By overriding the format file filter and canonicalizing the path, we can
force ListingTable to work with the single file we pass as the argument
to `vx browse`

Signed-off-by: Andrew Duffy <andrew@a10y.dev>
@a10y a10y force-pushed the aduffy/fix-df-crawl branch from 771b78f to b374ab3 Compare June 17, 2026 14:52
@a10y a10y enabled auto-merge (squash) June 17, 2026 14:58
@a10y a10y merged commit 8058097 into develop Jun 17, 2026
74 of 76 checks passed
@a10y a10y deleted the aduffy/fix-df-crawl branch June 17, 2026 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/fix A bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants