Skip to content

fix(spark): warn that overwrite destructively deletes existing files #8767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robert3005 merged 1 commit into from
Jul 15, 2026
+8 −2
Merged

fix(spark): warn that overwrite destructively deletes existing files #8767

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions java/vortex-spark/src/main/java/dev/vortex/spark/write/VortexBatchWrite.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,9 +90,15 @@ public DataWriterFactory createBatchWriterFactory(PhysicalWriteInfo info) {
if (overwrite) {
var session = VortexSparkSession.get(options);
var uris = NativeFiles.listFiles(session, outputPath, options);
log.info("truncating table with {} files", uris.size());
// Deleting the existing files is destructive and happens before the new data is written:
// if the subsequent write fails, abort() only removes the newly written files and cannot
// restore what was deleted here. Log loudly so operators can see what was removed.
log.warn(
"Deleting {} existing file(s) under {} because of overwrite, before writing new data; "
+ "this cannot be undone if the subsequent write fails",
uris.size(),
outputPath);
NativeFiles.delete(session, uris.toArray(new String[0]), options);
log.warn("overwrite currently does not do anything for vortex format");
}

return new VortexDataWriterFactory(outputPath, schema, options, resolvedTransforms);
Expand Down
Loading