Propagate Union nullability to its variants#8768
Draft
connortsui20 wants to merge 1 commit into
Draft
Conversation
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Member
Author
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
A
Unionhas no top-level nullability of its own; its nullability is derived from its variant dtypes. GenericDType::as_nullableandDType::as_nonnullabletherefore need to propagate the requested nullability into every variant rather than returning the union unchanged.This is split from #8739 so the DType behavior can be reviewed independently from
UnionScalarsupport.What changes are included in this PR?
DType::with_nullabilitypropagate throughUnionVariantsUnionVariants::with_nullabilityWhat APIs are changed? Are there any user-facing changes?
UnionVariants::with_nullabilityis a new public API. CallingDType::as_nullable,DType::as_nonnullable, orDType::with_nullabilityon a union now updates every variant dtype.Validation
cargo nextest run -p vortex-array test_with_nullability_propagates_to_variantscargo +nightly fmt --all -- --checkcargo clippy -p vortex-array --all-targets --all-featuresWorkspace-wide Clippy could not complete locally because the DuckDB build could not find
duckdb.h.