Skip to content

Use u8 Union type IDs#8790

Merged
connortsui20 merged 1 commit into
developfrom
agent/union-type-ids-u8
Jul 16, 2026
Merged

Use u8 Union type IDs#8790
connortsui20 merged 1 commit into
developfrom
agent/union-type-ids-u8

Conversation

@connortsui20

@connortsui20 connortsui20 commented Jul 16, 2026

Copy link
Copy Markdown
Member

Tracking issue: #8769 and #7882

Splits the type-ID foundation for #8769 into its own change.

  • changes Union variant type IDs from i8 to u8 across the dtype APIs, protobuf, FlatBuffers, and generated bindings
  • supports the full u8 tag range
  • supports up to 256 Union variants with consecutive tags 0..=255

@github-actions

github-actions Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Polar Signals Profiling Results

Latest Run

Status Commit Job Attempt Link
🟢 Done 2eb8864 1 Explore Profiling Data
Previous Runs (4)
Status Commit Job Attempt Link
🟢 Done 378b981 1 Explore Profiling Data
🟢 Done 2c72940 1 Explore Profiling Data
🟢 Done d9583d3 1 Explore Profiling Data
🟢 Done 7820b66 1 Explore Profiling Data

Powered by Polar Signals Cloud

@github-actions

github-actions Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Benchmarks: Vortex queries

Verdict: No clear signal (low confidence)
Attributed Vortex impact: +1.9%
Engines: DataFusion No clear signal (+9.6%, medium confidence) · DuckDB No clear signal (-5.4%, low confidence)
Vortex (geomean): 0.947x ➖
Parquet (geomean): 0.938x ➖
Shifts: Parquet (control) -6.2% · Median polish -5.1%

How to read Verdict and Engines
  • Verdict: Overall PR-level signal after subtracting baseline drift estimated from Parquet control rows. It can be Likely improvement, Likely regression, or No clear signal.
  • Engines: Per-engine attribution. DataFusion is compared against DataFusion/Parquet controls; DuckDB is compared against DuckDB/Parquet controls. This answers whether each engine improved or regressed independently.
  • Confidence: Based on directional consistency, share of rows above the noise floor, and control-run noise.

datafusion / vortex-file-compressed (0.990x ➖, 0↑ 0↓)
name PR 2eb8864 (ns) base 8f75dbe (ns) ratio (PR/base)
vortex_q00/datafusion:vortex-file-compressed 9935024 9766676 1.02
vortex_q01/datafusion:vortex-file-compressed 6252967 6494068 0.96
datafusion / parquet (0.903x ➖, 1↑ 0↓)
name PR 2eb8864 (ns) base 8f75dbe (ns) ratio (PR/base)
vortex_q00/datafusion:parquet 🚀 19415579 21678477 0.90
vortex_q01/datafusion:parquet 4472598 4916579 0.91
duckdb / vortex-file-compressed (0.923x ➖, 0↑ 0↓)
name PR 2eb8864 (ns) base 8f75dbe (ns) ratio (PR/base)
vortex_q00/duckdb:vortex-file-compressed 9914440 10671677 0.93
vortex_q01/duckdb:vortex-file-compressed 6042909 6589104 0.92
duckdb / parquet (0.975x ➖, 0↑ 0↓)
name PR 2eb8864 (ns) base 8f75dbe (ns) ratio (PR/base)
vortex_q00/duckdb:parquet 23279550 23744732 0.98
vortex_q01/duckdb:parquet 9377013 9666241 0.97

No file size changes detected.

@connortsui20 connortsui20 added the changelog/chore A trivial change label Jul 16, 2026
@connortsui20
connortsui20 force-pushed the agent/union-type-ids-u8 branch 2 times, most recently from d9583d3 to 2c72940 Compare July 16, 2026 15:46
@connortsui20
connortsui20 marked this pull request as ready for review July 16, 2026 15:55
@connortsui20
connortsui20 force-pushed the agent/union-type-ids-u8 branch from 2c72940 to 378b981 Compare July 16, 2026 16:02
@connortsui20
connortsui20 marked this pull request as draft July 16, 2026 16:02
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
@connortsui20
connortsui20 force-pushed the agent/union-type-ids-u8 branch from 378b981 to 2eb8864 Compare July 16, 2026 16:08
@connortsui20
connortsui20 marked this pull request as ready for review July 16, 2026 16:48
@connortsui20
connortsui20 merged commit 17f843a into develop Jul 16, 2026
74 checks passed
@connortsui20
connortsui20 deleted the agent/union-type-ids-u8 branch July 16, 2026 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants