Skip to content

Rename vortex_bench_dir to bench_results_dir #8817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joseph-isaacs wants to merge 1 commit into from
+5 −3
Closed

Rename vortex_bench_dir to bench_results_dir #8817

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions vortex-bench/src/output.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,9 @@ impl BenchmarkOutput {
///
/// Returns `target/vortex-bench/<benchmark_id>/results.json`.
pub fn default_output_path(benchmark_id: &str) -> PathBuf {
vortex_bench_dir().join(benchmark_id).join(DEFAULT_FILENAME)
bench_results_dir()
.join(benchmark_id)
.join(DEFAULT_FILENAME)
}

/// Create an appropriate writer based on display format and output path.
Expand All @@ -106,10 +108,10 @@ pub fn create_output_writer(
}
}

/// Get the base directory for vortex benchmark results.
/// Get the base directory for benchmark results.
///
/// Returns `target/vortex-bench/`.
pub fn vortex_bench_dir() -> PathBuf {
pub fn bench_results_dir() -> PathBuf {
workspace_root().join("target").join("vortex-bench")
}

Expand Down
Loading