Skip to content

Avoid redundant allocations in struct layout reader #8851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joseph-isaacs merged 1 commit into from
Jul 20, 2026
+10 −10
Merged

Avoid redundant allocations in struct layout reader #8851

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions vortex-layout/src/layouts/struct_/reader.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,17 +82,17 @@ impl StructReader {
.collect()
});

let mut dtypes: Vec<DType> = struct_dt.fields().collect();
let mut names: Vec<Arc<str>> = struct_dt
.names()
.iter()
.map(|x| Arc::clone(x.inner()))
.collect();

if layout.dtype.is_nullable() {
dtypes.insert(0, DType::Bool(Nullability::NonNullable));
names.insert(0, Arc::from("validity"));
let nullable = layout.dtype.is_nullable();
let extra = nullable as usize;

let mut dtypes: Vec<DType> = Vec::with_capacity(struct_dt.nfields() + extra);
let mut names: Vec<Arc<str>> = Vec::with_capacity(struct_dt.nfields() + extra);
if nullable {
dtypes.push(DType::Bool(Nullability::NonNullable));
names.push(Arc::from("validity"));
}
dtypes.extend(struct_dt.fields());
names.extend(struct_dt.names().iter().map(|x| Arc::clone(x.inner())));

let lazy_children = LazyReaderChildren::new(
Arc::clone(&layout.children),
Expand Down
Loading