test(spark): characterize VortexBatchExec input partition planning#8859
Open
jackylee-ch wants to merge 1 commit into
Open
test(spark): characterize VortexBatchExec input partition planning#8859jackylee-ch wants to merge 1 commit into
jackylee-ch wants to merge 1 commit into
Conversation
robert3005
approved these changes
Jul 21, 2026
Merging this PR will improve performance by 11.17%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | Simulation | true_count_vortex_buffer[128] |
580.6 ns | 522.2 ns | +11.17% |
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing jackylee-ch:spark-batch-exec-tests (76202cd) with develop (b7b01d3)
Footnotes
-
44 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
Signed-off-by: jackylee <qcsd2011@gmail.com>
jackylee-ch
force-pushed
the
spark-batch-exec-tests
branch
from
July 21, 2026 10:32
76202cd to
3ac4c0e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
VortexBatchExec(java/vortex-spark/src/main/java/dev/vortex/spark/read/VortexBatchExec.java)turns the scan's resolved paths into Spark
InputPartitions, and it currently has nodirect test coverage. Its planning contract is easy to break silently: each
.vortexfile must become exactly one
VortexFilePartition, each partition must carry theHive-style partition values parsed from its own path (not a neighbour's), and the
read schema and format options must survive into every partition — these are what the
executor-side reader relies on to materialize partition columns correctly. This
continues the characterization-test series from #8770, #8782, #8783, #8850, and #8857.
What changes are included in this PR?
A new
VortexBatchExecTestwith 5 tests coveringplanInputPartitionsfor explicit.vortexpaths (which never touch native directory listing, keeping this a pure unittest):
VortexFilePartitionper file, each holding exactly one path;year=2024/month=01vs
year=2025/month=02vs an unpartitioned path yielding an empty map);This is a test-only change; no production code is modified. All 5 tests pass
locally on both matrix legs (
:vortex-spark_2.12:testand:vortex-spark_2.13:testwith
--tests 'dev.vortex.spark.read.VortexBatchExecTest').What APIs are changed? Are there any user-facing changes?
None. No production code or public API is touched.