Unify primitive and decimal physical storage#8864
Conversation
Polar Signals Profiling ResultsLatest Run
Previous Runs (5)
Powered by Polar Signals Cloud |
Benchmarks: Vortex queries 📖Verdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (0.911x ➖, 0↑ 0↓)
datafusion / parquet (0.854x ✅, 2↑ 0↓)
duckdb / vortex-file-compressed (0.877x ✅, 1↑ 0↓)
duckdb / parquet (0.961x ➖, 0↑ 0↓)
No file size changes detected. |
Merging this PR will improve performance by 72.44%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | Simulation | varbinview_large |
411 µs | 164.7 µs | ×2.5 |
| ⚡ | Simulation | copy_nullable[65536] |
1,362.6 µs | 579.4 µs | ×2.4 |
| ⚡ | Simulation | copy_non_nullable[65536] |
1,094.7 µs | 799.7 µs | +36.88% |
| ⚡ | Simulation | fsl_large |
99.6 µs | 90.5 µs | +10.06% |
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing ct/fixed-width-primitive-decimal (f124538) with develop (5b688a9)
Footnotes
-
3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
76fd71a to
f00395e
Compare
35a4157 to
2e0b1e2
Compare
2e0b1e2 to
35a4157
Compare
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
35a4157 to
2880b5f
Compare
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
2880b5f to
f124538
Compare
## Summary - remove the unused `ArrayRef::is_arrow` helper - keep this reviewer-requested cleanup separate from #8864 ## Testing - `cargo check -p vortex-array` - `cargo clippy --all-targets --all-features` (pre-push hook) Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Summary
FixedWidthData/FixedWidthTypestorage for canonical Primitive and Decimal arraysCompatibility
The existing
vortex.primitiveandvortex.decimalIDs and their serialized layouts remain unchanged. The historical compatibility suite passed all 455 published fixtures across Vortex 0.64.0 and 0.68.0 through 0.79.0 on the combined implementation.