break[array]: Remove unimplemented child() method from VTable implementations#8870
Merged
Merged
Conversation
Both Patched and PythonVTable overrode VTable::child with behavior identical to the trait default: all four Patched slots are required (always Some), so the default idx-th non-None slot lookup returns exactly slots[idx], and PythonArray has no slots with nchildren() == 0, so its panicking override was unreachable behind the idx < nchildren guard in every caller. Signed-off-by: Claude <noreply@anthropic.com> Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk> Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XbjnDVZQ9KqXgAAhxy9g7D
Merging this PR will not alter performance
Comparing 
Footnotes
|
Every encoding used the default "idx-th non-None slot" definition, so the trait method was not a real customization point. Inline that definition into the DynArrayData children/nth_child/named_children implementations and drop the method from the vtable. Signed-off-by: Claude <noreply@anthropic.com> Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk> Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XbjnDVZQ9KqXgAAhxy9g7D
Contributor
Polar Signals Profiling ResultsLatest Run
Previous Runs (5)
Powered by Polar Signals Cloud |
Contributor
Benchmarks: Vortex queries 📖Verdict: No clear signal (environment too noisy confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (1.245x ❌, 0↑ 2↓)
datafusion / parquet (1.173x ❌, 0↑ 1↓)
duckdb / vortex-file-compressed (1.124x ❌, 0↑ 2↓)
duckdb / parquet (1.046x ➖, 0↑ 0↓)
No file size changes detected. |
Same treatment as VTable::child: the only override (PythonVTable) matched the default, so the method was not a real customization point. Signed-off-by: Claude <noreply@anthropic.com> Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk> Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XbjnDVZQ9KqXgAAhxy9g7D
joseph-isaacs
added
action/benchmark
github-actions
Bot
removed
the
action/benchmark
children/nchildren/nth_child/named_children no longer need the encoding vtable: implement them directly on ArrayRef over a single children_iter helper (the non-None slots in order) and drop them from DynArrayData. Only children_names still dispatches, for VTable::child_name. Signed-off-by: Claude <noreply@anthropic.com> Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk> Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XbjnDVZQ9KqXgAAhxy9g7D
joseph-isaacs
force-pushed
the
claude/remove-array-vtable-child-92x64s
branch
from
July 21, 2026 09:43
d39327e to
83dbd9d
Compare
joseph-isaacs
marked this pull request as ready for review
July 21, 2026 09:50
Contributor
Benchmarks: PolarSignals Profiling 📖Vortex (geomean): 1.047x ➖ How to read Verdict and Engines
datafusion / vortex-file-compressed (1.047x ➖, 0↑ 3↓)
No file size changes detected. |
Contributor
Benchmarks: FineWeb NVMe 📖Verdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (0.926x ➖, 4↑ 0↓)
datafusion / vortex-compact (0.921x ➖, 1↑ 0↓)
datafusion / parquet (0.899x ✅, 5↑ 0↓)
duckdb / vortex-file-compressed (0.945x ➖, 2↑ 0↓)
duckdb / vortex-compact (0.932x ➖, 1↑ 0↓)
duckdb / parquet (0.943x ➖, 0↑ 0↓)
No file size changes detected. |
The default child_name was just slot_name of the idx-th non-None slot, and the only override (PythonVTable) was unreachable. children_names now lives on ArrayRef next to the other child accessors, leaving slot_name as the single vtable source of child names. named_children stays as the public zip of children_names and children_iter for its external users. Signed-off-by: Claude <noreply@anthropic.com> Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk> Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XbjnDVZQ9KqXgAAhxy9g7D
Contributor
Benchmarks: TPC-H SF=1 on NVME 📖Verdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (1.041x ➖, 0↑ 0↓)
datafusion / vortex-compact (0.996x ➖, 0↑ 0↓)
datafusion / parquet (1.002x ➖, 1↑ 0↓)
datafusion / arrow (1.042x ➖, 0↑ 2↓)
duckdb / vortex-file-compressed (0.999x ➖, 0↑ 0↓)
duckdb / vortex-compact (1.008x ➖, 0↑ 0↓)
duckdb / parquet (0.964x ➖, 4↑ 1↓)
duckdb / duckdb (0.969x ➖, 0↑ 0↓)
No file size changes detected. |
joseph-isaacs
changed the title
joseph-isaacs
changed the title
Contributor
Benchmarks: TPC-DS SF=1 on NVME 📖Verdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (0.995x ➖, 2↑ 0↓)
datafusion / vortex-compact (0.962x ➖, 17↑ 0↓)
datafusion / parquet (1.007x ➖, 1↑ 4↓)
duckdb / vortex-file-compressed (0.968x ➖, 14↑ 0↓)
duckdb / vortex-compact (0.991x ➖, 5↑ 2↓)
duckdb / parquet (1.006x ➖, 2↑ 2↓)
duckdb / duckdb (1.007x ➖, 1↑ 2↓)
No file size changes detected. |
Contributor
Benchmarks: FineWeb S3 📖Verdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (0.911x ➖, 0↑ 0↓)
datafusion / vortex-compact (0.996x ➖, 0↑ 0↓)
datafusion / parquet (1.004x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed (1.037x ➖, 0↑ 0↓)
duckdb / vortex-compact (1.052x ➖, 0↑ 1↓)
duckdb / parquet (0.970x ➖, 0↑ 0↓)
|
Contributor
Benchmarks: Statistical and Population Genetics 📖Verdict: No clear signal (low confidence) How to read Verdict and Engines
duckdb / vortex-file-compressed (1.017x ➖, 0↑ 0↓)
duckdb / vortex-compact (1.012x ➖, 0↑ 0↓)
duckdb / parquet (1.014x ➖, 0↑ 0↓)
No file size changes detected. |
Contributor
Benchmarks: Clickbench Sorted on NVME 📖Verdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (0.871x ✅, 8↑ 1↓)
datafusion / parquet (0.866x ✅, 8↑ 0↓)
duckdb / vortex-file-compressed (0.876x ✅, 8↑ 0↓)
duckdb / parquet (0.892x ✅, 3↑ 0↓)
duckdb / duckdb (0.906x ➖, 3↑ 0↓)
File Size Changes (201 files changed, +0.0% overall, 102↑ 99↓)
Totals:
|
Contributor
Benchmarks: TPC-H SF=10 on NVME 📖Verdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (1.004x ➖, 0↑ 0↓)
datafusion / vortex-compact (0.994x ➖, 0↑ 0↓)
datafusion / parquet (0.993x ➖, 0↑ 0↓)
datafusion / arrow (0.983x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed (0.994x ➖, 0↑ 0↓)
duckdb / vortex-compact (0.991x ➖, 0↑ 0↓)
duckdb / parquet (0.995x ➖, 0↑ 0↓)
duckdb / duckdb (0.997x ➖, 0↑ 0↓)
No file size changes detected. |
Contributor
Benchmarks: Clickbench on NVME 📖Verdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (0.994x ➖, 2↑ 1↓)
datafusion / parquet (0.997x ➖, 0↑ 1↓)
duckdb / vortex-file-compressed (0.992x ➖, 0↑ 2↓)
duckdb / parquet (0.996x ➖, 0↑ 1↓)
duckdb / duckdb (0.996x ➖, 0↑ 0↓)
File Size Changes (1 files changed, -0.0% overall, 0↑ 1↓)
Totals:
|
Contributor
Benchmarks: TPC-H SF=1 on S3 📖Verdict: No clear signal (environment too noisy confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (0.990x ➖, 0↑ 0↓)
datafusion / vortex-compact (0.971x ➖, 1↑ 0↓)
datafusion / parquet (1.029x ➖, 0↑ 1↓)
duckdb / vortex-file-compressed (0.982x ➖, 0↑ 0↓)
duckdb / vortex-compact (1.019x ➖, 0↑ 0↓)
duckdb / parquet (0.978x ➖, 0↑ 0↓)
|
Contributor
Benchmarks: Appian on NVME 📖Verdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (0.950x ➖, 0↑ 0↓)
datafusion / parquet (0.940x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed (0.957x ➖, 0↑ 0↓)
duckdb / parquet (0.965x ➖, 0↑ 0↓)
duckdb / duckdb (0.956x ➖, 0↑ 0↓)
File Size Changes (1 files changed, -0.0% overall, 0↑ 1↓)
Totals:
|
Contributor
Benchmarks: TPC-H SF=10 on S3 📖Verdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (1.035x ➖, 0↑ 0↓)
datafusion / vortex-compact (0.981x ➖, 0↑ 0↓)
datafusion / parquet (1.016x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed (1.034x ➖, 0↑ 0↓)
duckdb / vortex-compact (1.035x ➖, 0↑ 0↓)
duckdb / parquet (1.039x ➖, 0↑ 0↓)
|
Contributor
Benchmarks: Random Access 📖Vortex (geomean): 0.980x ➖ How to read Verdict and Engines
unknown / unknown (0.984x ➖, 0↑ 0↓)
|
Contributor
Benchmarks: Compression 📖Vortex (geomean): 1.004x ➖ How to read Verdict and Engines
unknown / unknown (1.002x ➖, 0↑ 2↓)
|
gatesn
approved these changes
Jul 21, 2026
robert3005
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove unneeded methods
childandnchildrenfrom the vtable these always have a default impl and so are uneeded.Break
While this is a VTable break it likely used outside of vortex.