Skip to content

BufferIterator can be Send + Sync#8873

Open
robert3005 wants to merge 1 commit into
developfrom
rk/bufferiter
Open

BufferIterator can be Send + Sync#8873
robert3005 wants to merge 1 commit into
developfrom
rk/bufferiter

Conversation

@robert3005

@robert3005 robert3005 commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

BufferIterator is Send and Sync just like Vec IntoIter, fix #8869

Signed-off-by: Robert Kruszewski <github@robertk.io>
@robert3005 robert3005 added the changelog/chore A trivial change label Jul 21, 2026
@github-actions

github-actions Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Polar Signals Profiling Results

Latest Run

Status Commit Job Attempt Link
🟢 Done fdaf786 1 Explore Profiling Data

Powered by Polar Signals Cloud

@github-actions

Copy link
Copy Markdown
Contributor

Benchmarks: Vortex queries 📖

Verdict: No clear signal (low confidence)
Attributed Vortex impact: +5.2%
Engines: DataFusion No clear signal (+7.3%, low confidence) · DuckDB No clear signal (+3.2%, low confidence)
Vortex (geomean): 1.008x ➖
Parquet (geomean): 0.983x ➖
Shifts: Parquet (control) -1.7% · Median polish +1.1%

How to read Verdict and Engines
  • Verdict: Overall PR-level signal after subtracting baseline drift estimated from Parquet control rows. It can be Likely improvement, Likely regression, or No clear signal.
  • Engines: Per-engine attribution. DataFusion is compared against DataFusion/Parquet controls; DuckDB is compared against DuckDB/Parquet controls. This answers whether each engine improved or regressed independently.
  • Confidence: Based on directional consistency, share of rows above the noise floor, and control-run noise.

datafusion / vortex-file-compressed (1.041x ➖, 0↑ 0↓)
name PR fdaf786 (ns) base 39f4abe (ns) ratio (PR/base)
vortex_q00/datafusion:vortex-file-compressed 9786474 9523459 1.03
vortex_q01/datafusion:vortex-file-compressed 6324871 5998335 1.05
datafusion / parquet (0.970x ➖, 0↑ 0↓)
name PR fdaf786 (ns) base 39f4abe (ns) ratio (PR/base)
vortex_q00/datafusion:parquet 20218238 20757506 0.97
vortex_q01/datafusion:parquet 4532087 4691686 0.97
duckdb / vortex-file-compressed (1.027x ➖, 0↑ 0↓)
name PR fdaf786 (ns) base 39f4abe (ns) ratio (PR/base)
vortex_q00/duckdb:vortex-file-compressed 10103765 10315691 0.98
vortex_q01/duckdb:vortex-file-compressed 6742507 6256783 1.08
duckdb / parquet (0.996x ➖, 0↑ 0↓)
name PR fdaf786 (ns) base 39f4abe (ns) ratio (PR/base)
vortex_q00/duckdb:parquet 23436087 23377171 1.00
vortex_q01/duckdb:parquet 9421921 9525013 0.99

No file size changes detected.

@robert3005
robert3005 enabled auto-merge (squash) July 21, 2026 09:40
@robert3005
robert3005 requested a review from joseph-isaacs July 21, 2026 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] BufferIterator should have implemented Send and Sync

1 participant