Add C++ and CMake pre-commit hooks#568
Merged
Merged
Conversation
Contributor
Author
|
Need to remove vortex-auv from here before merging: https://github.com/organizations/vortexntnu/settings/installations/57321089 |
kluge7
changed the title
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #568 +/- ##
=======================================
Coverage 24.01% 24.01%
=======================================
Files 38 38
Lines 2286 2286
Branches 612 612
=======================================
Hits 549 549
Misses 1588 1588
Partials 149 149
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
kluge7
force-pushed
the
ci/add-cpp-pre-commit
branch
3 times, most recently
from
6feccc6 to
f815477
Compare
Contributor
Author
Don't need to do this, made a separate config file for the local pre-commit hooks. To run locally: pre-commit run --all-files -c .pre-commit-config-local.yamlCould also be an idea to make a script which runs both |
kluge7
force-pushed
the
ci/add-cpp-pre-commit
branch
from
e44d1b0 to
f394a99
Compare
kluge7
force-pushed
the
ci/add-cpp-pre-commit
branch
from
6c060f2 to
afd6e40
Compare
…ce conflict with clang-format
kluge7
force-pushed
the
ci/add-cpp-pre-commit
branch
from
7058487 to
4e1e52b
Compare
…auv into ci/add-cpp-pre-commit
…plint due to some lines being longer
kluge7
force-pushed
the
ci/add-cpp-pre-commit
branch
from
f128a79 to
53ad5fe
Compare
…ence_filter_utils.hpp
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 32 out of 32 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
anbit-adhi
pushed a commit
that referenced
this pull request
Jan 6, 2026
* ci(pre-commit): add CI workflow for checking pre-commit hooks * ci(pre-commit): add hooks for cpp and CMake * refactor(pre-commit.yml): now uses the workflow on main * docs(README.md): update status badge for pre-commit * refactor(ci): move local hooks into a different config file * docs(README.md): update status badge for pre-commit * refactor(ci): pre-commit.yml now only runs on pull_request and workflow_dispatch * ci(pre-commit-local): ignore build/include_order in ament_cpplint since conflict with clang-format * refactor: fix ament_cpplint and cppcheck warnings * ci(pre-commit-config-local): increase line length to 120 for ament_cpplint due to some lines being longer * refactor: fix ament_cpplint and cppcheck warnings * chore(pre-commit): exclude test dirs from ament_cppcheck to avoid false positives * ci(pre-commit): update workflow to run on push to main and pull_request
CurryMonsters
pushed a commit
that referenced
this pull request
Jan 23, 2026
* ci(pre-commit): add CI workflow for checking pre-commit hooks * ci(pre-commit): add hooks for cpp and CMake * refactor(pre-commit.yml): now uses the workflow on main * docs(README.md): update status badge for pre-commit * refactor(ci): move local hooks into a different config file * docs(README.md): update status badge for pre-commit * refactor(ci): pre-commit.yml now only runs on pull_request and workflow_dispatch * ci(pre-commit-local): ignore build/include_order in ament_cpplint since conflict with clang-format * refactor: fix ament_cpplint and cppcheck warnings * ci(pre-commit-config-local): increase line length to 120 for ament_cpplint due to some lines being longer * refactor: fix ament_cpplint and cppcheck warnings * chore(pre-commit): exclude test dirs from ament_cppcheck to avoid false positives * ci(pre-commit): update workflow to run on push to main and pull_request
|
🎉 This PR is included in version 2.6.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.