Merge .pre-commit-config-local.yaml and .pre-commit-config.yaml#644
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR consolidates the pre-commit configuration by merging .pre-commit-config-local.yaml into .pre-commit-config.yaml, simplifying local development setup by requiring only a single configuration file.
Key Changes:
- Merged ROS2-specific ament linter hooks (ament_cppcheck, ament_cpplint, ament_lint_cmake) from the local config into the main pre-commit config
- Removed the separate
.pre-commit-config-local.yamlfile - Updated GitHub Actions workflow to reference the unified configuration
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.pre-commit-config.yaml |
Added three local hooks for ROS2 ament linting (cppcheck, cpplint, and cmake) that were previously in the separate local config |
.pre-commit-config-local.yaml |
Deleted the separate local configuration file as its content has been merged into the main config |
.github/workflows/pre-commit.yml |
Updated config_path to point to the unified configuration file |
README.md |
Removed pre-commit.ci badge, consistent with disabling the pre-commit CI service |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
d0b443b to
97075b0
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #644 +/- ##
=======================================
Coverage 24.01% 24.01%
=======================================
Files 38 38
Lines 2286 2286
Branches 612 612
=======================================
Hits 549 549
Misses 1588 1588
Partials 149 149
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
🎉 This PR is included in version 2.6.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Done to make it simpler to run pre-commit locally, also updated the Github Actions pre-commit workflow to use this instead. Will also need to disable the pre-commit CI.