Skip to content

Merge .pre-commit-config-local.yaml and .pre-commit-config.yaml#644

Merged
kluge7 merged 1 commit into
mainfrom
refactor/pre-commit
Nov 16, 2025
Merged

Merge .pre-commit-config-local.yaml and .pre-commit-config.yaml#644
kluge7 merged 1 commit into
mainfrom
refactor/pre-commit

Conversation

@kluge7

@kluge7 kluge7 commented Nov 16, 2025

Copy link
Copy Markdown
Contributor

Done to make it simpler to run pre-commit locally, also updated the Github Actions pre-commit workflow to use this instead. Will also need to disable the pre-commit CI.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR consolidates the pre-commit configuration by merging .pre-commit-config-local.yaml into .pre-commit-config.yaml, simplifying local development setup by requiring only a single configuration file.

Key Changes:

  • Merged ROS2-specific ament linter hooks (ament_cppcheck, ament_cpplint, ament_lint_cmake) from the local config into the main pre-commit config
  • Removed the separate .pre-commit-config-local.yaml file
  • Updated GitHub Actions workflow to reference the unified configuration

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
.pre-commit-config.yaml Added three local hooks for ROS2 ament linting (cppcheck, cpplint, and cmake) that were previously in the separate local config
.pre-commit-config-local.yaml Deleted the separate local configuration file as its content has been merged into the main config
.github/workflows/pre-commit.yml Updated config_path to point to the unified configuration file
README.md Removed pre-commit.ci badge, consistent with disabling the pre-commit CI service

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/pre-commit.yml Outdated
@kluge7 kluge7 force-pushed the refactor/pre-commit branch from d0b443b to 97075b0 Compare November 16, 2025 20:53

@Andeshog Andeshog left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov

codecov Bot commented Nov 16, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 24.01%. Comparing base (19a8d11) to head (97075b0).
⚠️ Report is 79 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #644   +/-   ##
=======================================
  Coverage   24.01%   24.01%           
=======================================
  Files          38       38           
  Lines        2286     2286           
  Branches      612      612           
=======================================
  Hits          549      549           
  Misses       1588     1588           
  Partials      149      149           
Flag Coverage Δ
unittests 24.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kluge7 kluge7 merged commit 54caaa7 into main Nov 16, 2025
13 of 14 checks passed
@kluge7 kluge7 deleted the refactor/pre-commit branch November 16, 2025 21:15
@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 2.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants