Skip to content

Fix/landmark server#705

Merged
CurryMonsters merged 2 commits into
mainfrom
fix/landmark-server
Apr 3, 2026
Merged

Fix/landmark server#705
CurryMonsters merged 2 commits into
mainfrom
fix/landmark-server

Conversation

@CurryMonsters

Copy link
Copy Markdown
Member

fixed world ned, added logs for polling, updated compute target to use vortex utils, and added extra cancelling guard for landmark polling to help state machine.

@CurryMonsters CurryMonsters requested a review from jorgenfj April 2, 2026 19:24
@codecov

codecov Bot commented Apr 2, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 39.70%. Comparing base (264279b) to head (0c24b41).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...ission/landmark_server/src/landmark_server_ros.cpp 0.00% 7 Missing ⚠️
...andmark_server/src/landmark_server_convergence.cpp 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #705      +/-   ##
==========================================
+ Coverage   39.65%   39.70%   +0.04%     
==========================================
  Files          79       79              
  Lines        5338     5332       -6     
  Branches     1717     1719       +2     
==========================================
  Hits         2117     2117              
+ Misses       2775     2769       -6     
  Partials      446      446              
Flag Coverage Δ
unittests 39.70% <0.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...er/include/landmark_server/landmark_server_ros.hpp 0.00% <ø> (ø)
...andmark_server/src/landmark_server_convergence.cpp 0.00% <0.00%> (ø)
...ission/landmark_server/src/landmark_server_ros.cpp 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jorgenfj jorgenfj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@CurryMonsters CurryMonsters merged commit 8a0f2e8 into main Apr 3, 2026
16 checks passed
@CurryMonsters CurryMonsters deleted the fix/landmark-server branch April 3, 2026 08:23
@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 2.7.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants