Skip to content

Commit c8077bc

Browse files
committed
fixing last variable names
1 parent 5da97db commit c8077bc

3 files changed

Lines changed: 7 additions & 6 deletions

File tree

image-filtering/config/image_filtering_params.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@
4141
maxval: 255.
4242
invert: true
4343
temporal_noise:
44-
blur_sigma: 4.0
44+
median_kernel_size: 3
4545
power_law_weight: 4.0 # Weight for the gamma function
4646
erotion_size: 2
4747
dilation_size: 4

image-filtering/include/image_filtering/lib/filters/temporal_noise.hpp

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
/////////////////////////////
1010
namespace vortex::image_filtering {
1111
struct TemporalNoiseParams {
12-
double blur_sigma;
12+
int median_kernel_size;
1313
double power_law_weight;
1414

1515
int canny_low;
@@ -35,18 +35,19 @@ class TemporalNoise : public Filter {
3535

3636
inline void TemporalNoise::apply_filter(const cv::Mat& original,
3737
cv::Mat& filtered) const {
38-
const double sigma = filter_params_.blur_sigma;
38+
// const double sigma = filter_params_.blur_sigma;
3939
const double power_law_weight = filter_params_.power_law_weight;
4040
const int erosion_size = filter_params_.erotion_size;
4141
const int dilation_size = filter_params_.dilation_size;
4242
const int protect_radius = filter_params_.edge_protection_radius;
4343
const int canny_low = filter_params_.canny_low;
4444
const int canny_high = filter_params_.canny_high;
45+
const int median_kernel_size = filter_params_.median_kernel_size;
4546

4647
cv::Mat temp;
4748
original.copyTo(temp);
4849

49-
apply_median(temp, temp, 3);
50+
apply_median(temp, temp, median_kernel_size);
5051

5152
apply_auto_gamma(temp, power_law_weight);
5253

image-filtering/src/ros/image_filtering_ros.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -146,8 +146,8 @@ void ImageFilteringNode::set_filter_params() {
146146
}
147147
case FilterType::TemporalNoise: {
148148
TemporalNoiseParams params;
149-
params.blur_sigma = declare_and_get<double>(
150-
"filter_params.temporal_noise.blur_sigma");
149+
params.median_kernel_size = declare_and_get<int>(
150+
"filter_params.temporal_noise.median_kernel_size");
151151
params.power_law_weight = declare_and_get<double>(
152152
"filter_params.temporal_noise.power_law_weight");
153153
params.erotion_size = declare_and_get<int>(

0 commit comments

Comments
 (0)