Skip to content

Fixing brain operator bugs #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
brimoor wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fixing brain operator bugs #308

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions plugins/brain/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -560,7 +560,7 @@ def get_parameters(self, ctx, inputs):
view=metric_choices,
)

inputs.str(
inputs.int(
"replication_factor",
label="Replication factor",
description=(
Expand Down Expand Up @@ -741,7 +741,6 @@ def get_parameters(self, ctx, inputs):
inputs.str(
"index_name",
label="Index name",
required=True,
description=(
"An optional name of a MongoDB vector search index to use or "
"create"
Expand Down Expand Up @@ -2688,6 +2687,8 @@ def _inject_brain_secrets(ctx):
if key.startswith("FIFTYONE_BRAIN_SIMILARITY_"):
_key = key[len("FIFTYONE_BRAIN_SIMILARITY_") :].lower()
_backend, _key = _key.split("_", 1)
if _backend not in fob.brain_config.similarity_backends:
fob.brain_config.similarity_backends[_backend] = {}
fob.brain_config.similarity_backends[_backend][_key] = value


Expand Down
2 changes: 1 addition & 1 deletion plugins/brain/fiftyone.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: "@voxel51/brain"
description: Utilities for working with the FiftyOne Brain
version: 1.3.0
version: 1.3.1
fiftyone:
version: ">=0.22"
url: https://github.com/voxel51/fiftyone-plugins/tree/main/plugins/brain
Expand Down
2 changes: 2 additions & 0 deletions plugins/zoo/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -743,6 +743,8 @@ def _inject_brain_secrets(ctx):
if key.startswith("FIFTYONE_BRAIN_SIMILARITY_"):
_key = key[len("FIFTYONE_BRAIN_SIMILARITY_") :].lower()
_backend, _key = _key.split("_", 1)
if _backend not in fob.brain_config.similarity_backends:
fob.brain_config.similarity_backends[_backend] = {}
fob.brain_config.similarity_backends[_backend][_key] = value


Expand Down
2 changes: 1 addition & 1 deletion plugins/zoo/fiftyone.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: "@voxel51/zoo"
description: A collection of FiftyOne Zoo utilities
version: 1.3.1
version: 1.3.2
fiftyone:
version: ">=0.22"
url: https://github.com/voxel51/fiftyone-plugins/tree/main/plugins/zoo
Expand Down