WIP: MCAP image-annotation decoder + camera-tile overlay#7635
Draft
mozabes wants to merge 1 commit into
Draft
Conversation
…camera tile Adds the data path for 2D image annotations end-to-end through the decoder layer, with the camera tile's settings sidebar listing the annotation streams that match the selected source. No rendering on the image panel yet — that lands in a follow-up alongside the 3D SceneUpdate path. ### Decoder - New `IMAGE_ANNOTATIONS` visualization kind and renderer-neutral primitive types in `decoders/types.ts`: `ImageAnnotationCircle`, `ImageAnnotationPoints` (points / line-strip / line-loop / line-list), `ImageAnnotationText`, normalized `RgbaColor`. - New `FOXGLOVE_IMAGE_ANNOTATIONS_PAYLOAD` descriptor. - New `foxglove.image-annotations` decoder in `adapters/mcap/decoders/foxglove/image-annotations.ts`. Reads via the existing protobufjs schema cache; tolerates either enum-number or enum-string `type` and either camelCase or snake_case keys. - Registered in the Foxglove built-in decoder list. ### Scene inventory + sidebar - New `"image-annotation"` source type. The NuScenes POC inventory now lists per-camera annotation topics (`/CAM_*/image_annotations`) and their sync policies mirror the matching cameras. - `McapCameraTile`'s settings sidebar replaces the placeholder Show-overlays / Show-bounding-boxes / Show-track-ids checkboxes with a real Annotations section. Annotation streams are filtered by topic prefix against the selected camera; each row is a checkbox the user can toggle. Empty state shown when no annotations match.
Contributor
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (5)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Related Issues
WIP. First slice of the Foxglove annotations ticket: 2D image annotations end-to-end with auto-bind by topic prefix. 3D `SceneUpdate`, sidebar overlay UX, calibration projection, and dynamic channel discovery are follow-ups.
Stacks on #7633.
📋 What changes are proposed in this pull request?
Decoder layer
Scene inventory
Camera-tile overlay
🧪 How is this patch tested? If it is not, please explain why.
📝 Release Notes
Is this a user-facing change?
What areas of FiftyOne does this PR affect?