Commit c4d92cc
committed
Fix RDoc 6.16+ compatibility by relaxing the check
With RDoc 6.16.0, the following test started to fail:
~~~
1) Failure:
RdocTest#test_renders_inline_rdoc_strings_0 [test/rdoc_test.rb:19]:
Expected /<h1[^>]*>Hiya(<span><a href=\"#label-Hiya\">¶<\/a> <a href=\"#(documentation|top)\">↑<\/a><\/span>)?<\/h1>/ to match # encoding: ASCII-8BIT
# valid: true
"\n<h1 id=\"label-Hiya\"><a href=\"#label-Hiya\">Hiya</a></h1>\n".
2) Failure:
RdocTest#test_renders_rdoc_files_in_views_path_0 [test/rdoc_test.rb:25]:
Expected /<h1[^>]*>Hello From RDoc(<span><a href=\"#label-Hello\+From\+RDoc\">¶<\/a> <a href=\"#(documentation|top)\">↑<\/a><\/span>)?<\/h1>/ to match # encoding: ASCII-8BIT
# valid: true
"\n<h1 id=\"label-Hello+From+RDoc\"><a href=\"#label-Hello+From+RDoc\">Hello From RDoc</a></h1>\n".
~~~
and it is caused by this change: ruby/rdoc#1465
The error happens due to over-prescriptive RDoc check, it seems. Looking
into history, it seems the intention was just to check if RDoc works.
However, the check later started to look too much into details of
rendering.
Therefore, relax the check to look only for know text and basic
formatting and leave the rest as RDoc implementation detail.
Fixes sinatra#21311 parent 4062e36 commit c4d92cc
1 file changed
+2
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
19 | | - | |
| 19 | + | |
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
25 | | - | |
| 25 | + | |
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
| |||
0 commit comments