Skip to content

Commit eecb036

Browse files
committed
chore: remove obsolete AbortController TODOs
Both TODO comments (one calling out hwp's AbortController pattern as inspiration, one wondering if an AbortController could improve markAsEnded cleanup) are now resolved by the per-callback signal and external-signal commits.
1 parent 26b32b3 commit eecb036

1 file changed

Lines changed: 0 additions & 2 deletions

File tree

index.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
/* eslint-disable promise/prefer-await-to-then */
22

3-
// TODO: Get inspired by Matteos https://github.com/mcollina/hwp/blob/main/index.js, eg AbortController is nice?
43
// TODO: Check docs here https://tc39.es/ecma262/#sec-operations-on-iterator-objects
54
// TODO: Look into https://tc39.es/ecma262/#sec-iteratorclose / https://tc39.es/ecma262/#sec-asynciteratorclose
65
// TODO: See "iteratorKind" in https://tc39.es/ecma262/#sec-runtime-semantics-forin-div-ofbodyevaluation-lhs-stmt-iterator-lhskind-labelset – see how it loops and validates the returned values
@@ -125,7 +124,6 @@ export function bufferedAsyncMap (input, callback, options) {
125124
.map(item => item.return && item.return())
126125
);
127126

128-
// TODO: Could we use an AbortController to improve this? See eg. https://github.com/mcollina/hwp/pull/10
129127
bufferedPromises.splice(0);
130128
subIterators.splice(0);
131129

0 commit comments

Comments
 (0)