Skip to content

Use extended regular expression patters for better compatibility #412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bastelfreak merged 1 commit into from
Mar 14, 2026
Merged

Use extended regular expression patters for better compatibility #412

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions files/domain-validation.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,10 @@ if ! test -f "${certpath}"; then
fi

# Get all subject alternative names from the certificate
certdomains=$(openssl x509 -in "${certpath}" -text -noout | grep -oP 'DNS:[^\s,]*' | sed 's/^DNS://g;')
certdomains=$(openssl x509 -in "${certpath}" -text -noout | grep -oE 'DNS:[^[:space:],]*' | sed 's/^DNS://g;')

# Sort and uniq all domains. Drop all Domains which occure twice
result=$(printf '%s\n%s' "${certdomains}" "${domains}" | sort | uniq -c | grep -Pcv '^[ \t]*2[ \t]')
result=$(printf '%s\n%s' "${certdomains}" "${domains}" | sort | uniq -c | grep -Ecv '^[[:blank:]]*2[[:blank:]]')

# If all requested domains are already in the certificate, the $result will be 0 otherwise > 0
if [ "${result}" -eq 0 ]; then
Expand Down
Loading