Skip to content

Make compatible with /bin/sh, not all systems (FreeBSD) have /bin/bash#414

Merged
kenyon merged 1 commit into
voxpupuli:masterfrom
rvstaveren:fix-hook-sh-fbsd-compact
Apr 11, 2026
Merged

Make compatible with /bin/sh, not all systems (FreeBSD) have /bin/bash#414
kenyon merged 1 commit into
voxpupuli:masterfrom
rvstaveren:fix-hook-sh-fbsd-compact

Conversation

@rvstaveren

Copy link
Copy Markdown
Contributor

Pull Request (PR) description

The hook.sh.epp assumes /bin/bash, and uses bash style test operators ([[ and ]])

It isn't strictly required, and all of it can be implemented with basic /bin/sh constructs too, which will allow the hooks to work on FreeBSD (and other unices that don't have bash as /bin/bash)

This Pull Request (PR) fixes the following issues

No issue was filed for this PR, fix was directly implemented

@kenyon kenyon changed the title Make compatible with /bin/sh, not all systems (FreeBSD) have /bin/bash Make compatible with /bin/sh, not all systems (FreeBSD) have /bin/bash Apr 11, 2026
@kenyon kenyon added the enhancement New feature or request label Apr 11, 2026
@kenyon
kenyon merged commit ea3864d into voxpupuli:master Apr 11, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants