fix: refresh .link files via udev and manage networkd reliably#637
Merged
Conversation
kenyon
approved these changes
Jun 28, 2026
kenyon
left a comment
kenyon
left a comment
Member
There was a problem hiding this comment.
TIL that link files are read by systemd-udevd, not systemd-networkd 🙌
Contributor
Author
|
It would work either way, but added ordering to reduce churn |
jay7x
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
.link files in /etc/systemd/network are read by systemd-udevd, not
systemd-networkd, so notifying the networkd service never re-applied
changed .link files. Route them to a new udev reload exec
(udevadm control --reload && udevadm trigger --subsystem-match=net)
instead.
Also drop the systemd_internal_services fact guard on manage_networkd
(incorporates #596): networkd is an external package managed by this
module, so the fact isn't populated until a second Puppet run, leaving
the service unmanaged on the first run.