Conversion tests and fixes

Author: vpiotr

include/xnode.h

@@ -669,8 +669,9 @@ class basic_xnode {
 			return result;
 		}
 
-        if (!xnode_caster<T, typename value_policy::cast_policy>::cast_to_value(result, const_cast<void **>(&value_), vtable_->type_code_))
+        if (!xnode_caster<T, typename value_policy::cast_policy>::cast_to_value(result, const_cast<void **>(&value_), vtable_->type_code_)) {
             throwWrongCastToValue<T>();
+	    }
 		return result;
 	}
 

include/xnode_long_double.h

@@ -83,19 +83,19 @@ class xnode_caster<long double, xnode_ld_cast_policy> : xnode_caster_base {
 
         switch (srcTypeCode) {
             case xnode_type_code<double>::value: {
-                output = static_cast<ValueType>(*reinterpret_cast<double*>(*storage));
+                output = xnode_get_scalar<double>(storage);
                 break;
             }
             case xnode_type_code<float>::value: {
-                output = static_cast<ValueType>(*reinterpret_cast<float*>(*storage));
+                output = xnode_get_scalar<float>(storage);
                 break;
             }
             case xnode_type_code<long double>::value: {
-                output = *reinterpret_cast<long double*>(*storage);
+                output = xnode_get_scalar<long double>(storage);
                 break;
             }
             case xnode_type_code<int>::value: {
-                output = static_cast<ValueType>(*reinterpret_cast<int*>(*storage));
+                output = xnode_get_scalar<int>(storage);
                 break;
             }
             default: {

test.sh

@@ -1,3 +1,6 @@
+rm -f build/*
+rmdir -p build
+
 # Configure
 cmake -B build
 

test/CMakeLists.txt

@@ -4,8 +4,15 @@ target_link_libraries(xnode_test PRIVATE xnode)
 # Add test to CTest
 add_test(NAME xnode_test COMMAND xnode_test)
 
+# Add conversion tests
+add_executable(xnode_convert_test xnode_convert_test.cpp)
+target_link_libraries(xnode_convert_test PRIVATE xnode)
+
+# Add conversion test to CTest
+add_test(NAME xnode_convert_test COMMAND xnode_convert_test)
+
 # Install the test executable if needed (optional)
-install(TARGETS xnode_test
+install(TARGETS xnode_test xnode_convert_test
     RUNTIME DESTINATION bin
     OPTIONAL
 )