fix: change cookie value encoding from urlencode to rawurlencode#1208
Merged
Conversation
`urlencode` encodes space into `+`, which breaks `adminer_permanent`, which is space-separated.
peterpp
added a commit
to adminneo-org/adminneo
that referenced
this pull request
Nov 6, 2025
urlencode() encodes space into +, which breaks adminneo_permanent cookie that is space-separated. Thanks to @shunf4 (vrana/adminer#1208)
Owner
|
Thanks. I don't see what's wrong with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
urlencodeencodes space into+, which breaksadminer_permanent, which is space-separated.In current version if multiple connections are made permanent, they are not correctly handled when a new session is created.