Avoid percent-encoding for "(" and ")" characters.

The VRChat API does not accept percent-encoded variants of InstanceID, specifically the characters "(" and ")". This causes an error when attempting the following API call:
```
https://api.vrchat.cloud/api/1/instances/wrld_28aab3e4-953f-4c85-9223-ef29a0873a6e:31124%7Egroup%28grp_b2a19685-c53e-4c5a-9503-744a5373bf2c%29%7EgroupAccessType%28plus%29%7Eregion%28use%29/shortName
```
```json
{"error":{"message":"\"malformed url\"","status_code":400,"waf_code":26497}}
```

When using the raw string without encoding, the API yields a `200` response as expected.
```
https://vrchat.com/api/1/instances/wrld_28aab3e4-953f-4c85-9223-ef29a0873a6e:31124~group(grp_b2a19685-c53e-4c5a-9503-744a5373bf2c)~groupAccessType(plus)~region(use)/shortName
```

Author: Powerbyte7

generate.sh

@@ -32,6 +32,7 @@ printf "\n[dev-dependencies]\ntokio = { version = '1', features = ['macros', 'rt
 
 find src/ -type f -name "*.rs" -exec sed -i 's/models::models/models/g' {} +
 find src/ -type f -name "*.rs" -exec sed -i -E "s/(::)?std::path::PathBuf/crate::patches::better_file_upload::File<'_>/g" {} +
+find src/ -type f -name "*.rs" -exec sed -i -E "s/(::)?url::form_urlencoded::byte_serialize/crate::patches::percent_encoding::urlencode/g" {} +
 
 rm -r src/patches
 cp -r patches src/patches

patches/mod.rs

@@ -1 +1,2 @@
-pub mod better_file_upload;
+pub mod better_file_upload;
+pub mod percent_encoding;

patches/percent_encoding.rs

@@ -0,0 +1,39 @@
+
+fn hex_digit(b: u8) -> Option<u8> {
+    match b {
+        b'0'..=b'9' => Some(b - b'0'),
+        b'a'..=b'f' => Some(b - b'a' + 10),
+        b'A'..=b'F' => Some(b - b'A' + 10),
+        _ => None,
+    }
+}
+
+fn parse_percent_encoded(bytes: &[u8; 3]) -> Option<u8> {
+    if bytes[0] != b'%' { return None; }
+    let hi = hex_digit(bytes[1])?;
+    let lo = hex_digit(bytes[2])?;
+    Some((hi << 4) | lo)
+}
+
+pub fn urlencode<'a>(bytes: &'a [u8]) -> impl Iterator<Item = &'a str> {
+    ::url::form_urlencoded::byte_serialize(bytes)
+        .map(|string| {
+            debug_assert!(
+                !string.starts_with('%') || string.len() == 3,
+                "the iterator should yield percent-encoded strings of exactly 3 bytes, or unescaped strings"
+            );
+
+            let parsed = match string.as_bytes().try_into() {
+                Ok(bytes) => parse_percent_encoded(bytes),
+                Err(_) => None,
+            };
+
+            // The VRChat API deviates from the application/x-www-form-urlencoded percent-encode set, for values like the InstanceID.
+            // The characters bellow should remain unchanged for URI parameters, or requests will be rejected as malformed.
+            match parsed {
+                Some(b'(') => "(",
+                Some(b')') => ")",
+                _ => string
+            }
+        })
+}

src/apis/mod.rs

@@ -67,7 +67,7 @@ impl<T> From<std::io::Error> for Error<T> {
 }
 
 pub fn urlencode<T: AsRef<str>>(s: T) -> String {
-    ::url::form_urlencoded::byte_serialize(s.as_ref().as_bytes()).collect()
+    crate::patches::percent_encoding::urlencode(s.as_ref().as_bytes()).collect()
 }
 
 pub fn parse_deep_object(prefix: &str, value: &serde_json::Value) -> Vec<(String, String)> {

src/patches/mod.rs

@@ -1 +1,2 @@
 pub mod better_file_upload;
+pub mod percent_encoding;

src/patches/percent_encoding.rs

@@ -0,0 +1,39 @@
+
+fn hex_digit(b: u8) -> Option<u8> {
+    match b {
+        b'0'..=b'9' => Some(b - b'0'),
+        b'a'..=b'f' => Some(b - b'a' + 10),
+        b'A'..=b'F' => Some(b - b'A' + 10),
+        _ => None,
+    }
+}
+
+fn parse_percent_encoded(bytes: &[u8; 3]) -> Option<u8> {
+    if bytes[0] != b'%' { return None; }
+    let hi = hex_digit(bytes[1])?;
+    let lo = hex_digit(bytes[2])?;
+    Some((hi << 4) | lo)
+}
+
+pub fn urlencode<'a>(bytes: &'a [u8]) -> impl Iterator<Item = &'a str> {
+    ::url::form_urlencoded::byte_serialize(bytes)
+        .map(|string| {
+            debug_assert!(
+                !string.starts_with('%') || string.len() == 3,
+                "the iterator should yield percent-encoded strings of exactly 3 bytes, or unescaped strings"
+            );
+
+            let parsed = match string.as_bytes().try_into() {
+                Ok(bytes) => parse_percent_encoded(bytes),
+                Err(_) => None,
+            };
+
+            // The VRChat API deviates from the application/x-www-form-urlencoded percent-encode set, for values like the InstanceID.
+            // The characters bellow should remain unchanged for URI parameters, or requests will be rejected as malformed.
+            match parsed {
+                Some(b'(') => "(",
+                Some(b')') => ")",
+                _ => string
+            }
+        })
+}