Skip to content

Commit 5d5f491

Browse files
committed
Prevent drop shadow from appearing unnecessarily
1 parent d7be1ae commit 5d5f491

1 file changed

Lines changed: 7 additions & 4 deletions

File tree

src/vscode-scrollable/vscode-scrollable.ts

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -128,6 +128,8 @@ export class VscodeScrollable extends VscElement {
128128
private _scrollbarVisible = true;
129129
private _scrollbarTrackZ = 0;
130130

131+
//#region lifecycle methods
132+
131133
constructor() {
132134
super();
133135
this.addEventListener('mouseover', this._handleComponentMouseOver);
@@ -165,6 +167,8 @@ export class VscodeScrollable extends VscElement {
165167
this._updateThumbPosition();
166168
}
167169

170+
//#endregion
171+
168172
private _resizeObserverCallback = () => {
169173
this._updateScrollbar();
170174
this._updateThumbPosition();
@@ -218,15 +222,14 @@ export class VscodeScrollable extends VscElement {
218222
return;
219223
}
220224

221-
const scrollTop = this._scrollPos;
222-
this.scrolled = scrollTop > 0;
225+
this.scrolled = this.scrollPos > 0;
223226

224227
const componentH = this.offsetHeight;
225228
const thumbH = this._thumbHeight;
226229
const contentH = this._contentElement.offsetHeight;
227230

228231
const overflown = contentH - componentH;
229-
const ratio = scrollTop / overflown;
232+
const ratio = this.scrollPos / overflown;
230233
const thumbYMax = componentH - thumbH;
231234

232235
this._thumbY = Math.min(ratio * (componentH - thumbH), thumbYMax);
@@ -367,7 +370,7 @@ export class VscodeScrollable extends VscElement {
367370
.style=${stylePropertyMap({
368371
userSelect: this._isDragging ? 'none' : 'auto',
369372
})}
370-
.scrollTop=${this._scrollPos}
373+
.scrollTop=${this.scrollPos}
371374
@scroll=${this._handleScrollableContainerScroll}
372375
>
373376
<div

0 commit comments

Comments
 (0)