Skip to content

Commit bd27dad

Browse files
committed
Fix change event dispatching
1 parent edcf2da commit bd27dad

3 files changed

Lines changed: 6 additions & 10 deletions

File tree

dev/vscode-multi-select/combobox-suggestion-mode.html

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -224,14 +224,8 @@
224224
<vscode-option>Zimbabwe</vscode-option>
225225
</vscode-multi-select>
226226
<script type="module">
227-
const sl = document.querySelector('vscode-multi-select');
228-
sl.addEventListener('change', () => {
229-
console.log(sl.value);
230-
});
231-
232-
sl.addEventListener('vsc-multi-select-create-option', (ev) => {
233-
console.log(ev);
234-
});
227+
logEvents('vscode-multi-select', 'change');
228+
logEvents('vscode-multi-select', 'vsc-multi-select-create-option');
235229
</script>
236230
</vscode-demo>
237231
</main>

src/vscode-multi-select/vscode-multi-select.test.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -386,4 +386,5 @@ describe('vscode-multi-select', () => {
386386
it('selects multiple options with keyboard');
387387
it('selectedIndexes sync with values');
388388
it('creates and select suggested option (enter key press)');
389+
it('dispatch change event, set form value, manage required state (enter key press)');
389390
});

src/vscode-multi-select/vscode-multi-select.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -299,10 +299,11 @@ export class VscodeMultiSelect
299299
this._createAndSelectSuggestedOption();
300300
} else {
301301
this._opts.toggleActiveMultiselectOption();
302+
this._setFormValue();
303+
this._manageRequired();
304+
this._dispatchChangeEvent();
302305
}
303306
}
304-
305-
// TODO: dispatch change + set value
306307
}
307308

308309
private _onMultiAcceptClick(): void {

0 commit comments

Comments
 (0)