Skip to content

Commit c56f77c

Browse files
committed
Fine-tuning ARIA attributes
1 parent a6bff39 commit c56f77c

1 file changed

Lines changed: 6 additions & 9 deletions

File tree

src/includes/vscode-select/vscode-select-base.ts

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -611,6 +611,9 @@ export class VscodeSelectBase extends VscElement {
611611
return html`
612612
<ul
613613
aria-label=${ifDefined(this.label ?? undefined)}
614+
aria-multiselectable=${ifDefined(
615+
this._opts.multiSelect ? 'true' : undefined
616+
)}
614617
class="options"
615618
id="select-listbox"
616619
role="listbox"
@@ -752,16 +755,10 @@ export class VscodeSelectBase extends VscElement {
752755
<div class="combobox-face face">
753756
${this._multiple ? this._renderMultiSelectLabel() : nothing}
754757
<input
755-
aria-activedescendant=${ifDefined(
756-
this._opts.multiSelect ? undefined : activeDescendant
757-
)}
758+
aria-activedescendant=${activeDescendant}
758759
aria-autocomplete="list"
759-
aria-controls=${this._multiple
760-
? 'multi-select-listbox'
761-
: 'single-select-listbox'}
762-
aria-expanded=${ifDefined(
763-
this._opts.multiSelect ? undefined : expanded
764-
)}
760+
aria-controls="select-listbox"
761+
aria-expanded=${expanded}
765762
aria-haspopup="listbox"
766763
aria-label=${ifDefined(this.label)}
767764
class="combobox-input"

0 commit comments

Comments
 (0)