Skip to content

Commit c9b1205

Browse files
committed
Fix empty payload of vsc-tree-select
1 parent 341271e commit c9b1205

3 files changed

Lines changed: 26 additions & 3 deletions

File tree

CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,12 @@ All notable changes to this project will be documented in this file.
44

55
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
66

7+
## [Unreleased]
8+
9+
### Fixed
10+
11+
- **Tree**: Fixed the empty payload of the `vsc-tree-select` event.
12+
713
## [1.0.0] - 2024-01-04
814

915
### Added

dev/vscode-tree.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -220,7 +220,7 @@ <h2 class="story-title">Basic example</h2>
220220

221221
tree.data = data;
222222

223-
tree.addEventListener('vsc-select', (ev) => {
223+
tree.addEventListener('vsc-tree-select', (ev) => {
224224
console.log(ev);
225225
});
226226
});

src/vscode-tree/vscode-tree.ts

Lines changed: 19 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,19 @@ export type VscTreeActionEvent = CustomEvent<{
1515
value: string;
1616
}>;
1717

18+
export type VscTreeSelectEvent = CustomEvent<{
19+
icons: {
20+
branch?: string;
21+
open?: string;
22+
leaf?: string;
23+
};
24+
itemType: 'branch' | 'leaf';
25+
label: string;
26+
open: boolean;
27+
value: string;
28+
path: string;
29+
}>;
30+
1831
type ListenedKey = 'ArrowDown' | 'ArrowUp' | 'Enter' | 'Escape' | ' ';
1932

2033
type IconType = 'themeicon' | 'image';
@@ -740,7 +753,11 @@ export class VscodeTree extends VscElement {
740753
})
741754
);
742755

743-
this.dispatchEvent(new CustomEvent('vsc-tree-select'));
756+
this.dispatchEvent(
757+
new CustomEvent('vsc-tree-select', {
758+
detail,
759+
}) as VscTreeSelectEvent
760+
);
744761
}
745762

746763
private _focusPrevItem() {
@@ -905,7 +922,7 @@ declare global {
905922
}
906923

907924
interface GlobalEventHandlersEventMap {
908-
'vsc-tree-select': CustomEvent;
925+
'vsc-tree-select': VscTreeSelectEvent;
909926
'vsc-tree-action': VscTreeActionEvent;
910927
}
911928
}

0 commit comments

Comments
 (0)