From 990aad1a351c2a47a19b460ebb99a20c6304aba7 Mon Sep 17 00:00:00 2001 From: Anthony Stewart <150152+a-stewart@users.noreply.github.com> Date: Wed, 14 May 2025 01:17:10 +0200 Subject: [PATCH 1/2] Update vscode-button to only apply a margin to icons if there is slotted content --- src/vscode-button/vscode-button.styles.ts | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/vscode-button/vscode-button.styles.ts b/src/vscode-button/vscode-button.styles.ts index 78da388e7..767c54ccf 100644 --- a/src/vscode-button/vscode-button.styles.ts +++ b/src/vscode-button/vscode-button.styles.ts @@ -102,6 +102,7 @@ const styles: CSSResultGroup = [ justify-content: center; position: relative; width: 100%; + height: 100%; } slot { @@ -110,15 +111,16 @@ const styles: CSSResultGroup = [ height: 100%; } - .icon { + .icon, .icon-after { color: inherit; display: block; + } + + :host(:not(:empty)) .icon { margin-right: 3px; } - .icon-after { - color: inherit; - display: block; + :host(:not(:empty)) .icon-after, :host([icon]) .icon-after { margin-left: 3px; } `, From 737c68649eadcb22d6dd38f2fc32e687e247d4f4 Mon Sep 17 00:00:00 2001 From: Anthony Stewart <150152+a-stewart@users.noreply.github.com> Date: Wed, 14 May 2025 01:54:43 +0200 Subject: [PATCH 2/2] Also fix the margin-right on the last slotted child --- src/vscode-button/vscode-button.styles.ts | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/vscode-button/vscode-button.styles.ts b/src/vscode-button/vscode-button.styles.ts index 767c54ccf..86d67902a 100644 --- a/src/vscode-button/vscode-button.styles.ts +++ b/src/vscode-button/vscode-button.styles.ts @@ -91,6 +91,10 @@ const styles: CSSResultGroup = [ margin-left: 0; } + ::slotted(*:last-child) { + margin-right: 0; + } + ::slotted(vscode-icon) { color: inherit; }