Skip to content

Revert the focus style of the Button #440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bendera merged 2 commits into from
May 22, 2025
Merged

Revert the focus style of the Button #440

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
41e61fd
Revert :focus-visible to :focus
bendera May 22, 2025
287f87d
update changelog
bendera May 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,12 @@ All notable changes to this project will be documented in this file.

The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)

## [Unreleased]

### Fixed

- Reverted the original focus style of **Button**, as VSCode uses the `:focus` state instead of `focus-active`.

## [1.16.0] - 2025-05-17

### Added
Expand Down
6 changes: 3 additions & 3 deletions src/vscode-button/vscode-button.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ const styles: CSSResultGroup = [
outline: none;
}

:host(:focus-visible) {
:host(:focus) {
background-color: var(--vscode-button-hoverBackground, #026ec1);
outline: 1px solid var(--vscode-focusBorder, #0078d4);
outline-offset: 2px;
Expand Down Expand Up @@ -146,7 +146,7 @@ const styles: CSSResultGroup = [
}

:host(:hover) .divider,
:host(:focus-visible) .divider {
:host(:focus) .divider {
background-color: var(--vscode-button-hoverBackground, #026ec1);
}

Expand All @@ -155,7 +155,7 @@ const styles: CSSResultGroup = [
}

:host([secondary]:hover) .divider,
:host([secondary]:focus-visible) .divider {
:host([secondary]:focus) .divider {
background-color: var(--vscode-button-secondaryHoverBackground, #3c3c3c);
}

Expand Down