use one tracer instance

Author: shynome

bash/bash.go

@@ -20,7 +20,7 @@ import (
 	"go.opentelemetry.io/otel"
 )
 
-const name = "bash"
+var tracer = otel.Tracer("github.com/vscode-lcode/lcode/v2/bash")
 
 type Bash struct {
 	clients *ttlcache.Cache[string, *webdav.Client]
@@ -59,7 +59,7 @@ func (sh *Bash) Serve(l net.Listener) (err error) {
 }
 
 func (sh *Bash) serve(conn net.Conn) (err error) {
-	_, span := otel.Tracer(name).Start(context.Background(), "serve conn")
+	_, span := tracer.Start(context.Background(), "serve conn")
 	defer span.End()
 	defer err0.Record(&err, span)
 	defer err2.Handle(&err, func() {

bash/connect.go

@@ -16,7 +16,6 @@ import (
 	. "github.com/lainio/err2/try"
 	"github.com/vscode-lcode/lcode/v2/bash/webdav"
 	"github.com/vscode-lcode/lcode/v2/util/err0"
-	"go.opentelemetry.io/otel"
 )
 
 type ID interface {
@@ -34,7 +33,7 @@ type IDGenerator func(client LcodeClient) (ID, error)
 
 func (sh *Bash) Connect(r *bufio.Reader, conn net.Conn) (err error) {
 	defer conn.Close()
-	_, span := otel.Tracer(name).Start(context.Background(), "client connect")
+	_, span := tracer.Start(context.Background(), "client connect")
 	defer span.End()
 	defer err2.Handle(&err, func() {
 		if errors.Is(err, io.EOF) {

bash/webdav/client.go

@@ -27,7 +27,7 @@ import (
 	"go.opentelemetry.io/otel/trace"
 )
 
-const name = "bash/webdav"
+var tracer = otel.Tracer("github.com/vscode-lcode/lcode/v2/bash/webdav")
 
 type Client struct {
 	conn  net.Conn
@@ -69,7 +69,7 @@ func NewClient(conn net.Conn) *Client {
 }
 
 func (c *Client) Open(r *bufio.Reader, version string, id string) (err error) {
-	ctx, span := otel.Tracer(name).Start(context.Background(), "client open")
+	ctx, span := tracer.Start(context.Background(), "client open")
 	c.Ctx = ctx
 	defer err0.Record(&err, span)
 
@@ -102,7 +102,7 @@ func (c *Client) intFlag(version string) *flag.FlagSet {
 	return f
 }
 func (c *Client) parseArgs(r *bufio.Reader, version string) (err error) {
-	_, span := otel.Tracer(name).Start(c.Ctx, "client parse lcode args")
+	_, span := tracer.Start(c.Ctx, "client parse lcode args")
 	defer span.End()
 	defer err0.Record(&err, span)
 
@@ -126,7 +126,7 @@ func (c *Client) parseArgs(r *bufio.Reader, version string) (err error) {
 }
 
 func (c *Client) initServerAddr(r *bufio.Reader, id string) (err error) {
-	_, span := otel.Tracer(name).Start(c.Ctx, "client init server addr")
+	_, span := tracer.Start(c.Ctx, "client init server addr")
 	defer span.End()
 	defer err0.Record(&err, span)
 	defer err2.Handle(&err, func() {
@@ -153,7 +153,7 @@ func (c *Client) initServerAddr(r *bufio.Reader, id string) (err error) {
 }
 
 func (c *Client) initID(r *bufio.Reader) (err error) {
-	_, span := otel.Tracer(name).Start(c.Ctx, "client init id")
+	_, span := tracer.Start(c.Ctx, "client init id")
 	defer span.End()
 	defer err0.Record(&err, span)
 
@@ -171,7 +171,7 @@ func (c *Client) StoreID(id string) (err error) {
 }
 
 func (c *Client) initPWD(r *bufio.Reader) (err error) {
-	_, span := otel.Tracer(name).Start(c.Ctx, "client init pwd")
+	_, span := tracer.Start(c.Ctx, "client init pwd")
 	defer span.End()
 	defer err0.Record(&err, span)
 

bash/webdav/file.go

@@ -14,11 +14,10 @@ import (
 	"github.com/lainio/err2"
 	. "github.com/lainio/err2/try"
 	"github.com/vscode-lcode/lcode/v2/util/err0"
-	"go.opentelemetry.io/otel"
 )
 
 func (f *File) Readdir(count int) (files []fs.FileInfo, err error) {
-	_, span := otel.Tracer(name).Start(f.Ctx, "file readdir")
+	_, span := tracer.Start(f.Ctx, "file readdir")
 	defer span.End()
 	defer err0.Record(&err, span)
 
@@ -79,7 +78,7 @@ func (f *File) _Stat() (finfo fs.FileInfo, err error) {
 	return
 }
 func (f *File) _GetStat() (finfo fs.FileInfo, err error) {
-	_, span := otel.Tracer(name).Start(f.Ctx, "file stat")
+	_, span := tracer.Start(f.Ctx, "file stat")
 	defer span.End()
 	defer err2.Handle(&err, func() {
 		if errors.Is(err, os.ErrNotExist) {

bash/webdav/file2.go

@@ -15,7 +15,6 @@ import (
 	"github.com/lainio/err2"
 	. "github.com/lainio/err2/try"
 	"github.com/vscode-lcode/lcode/v2/util/err0"
-	"go.opentelemetry.io/otel"
 	"go.opentelemetry.io/otel/attribute"
 	"go.opentelemetry.io/otel/trace"
 	"golang.org/x/net/webdav"
@@ -47,7 +46,7 @@ var _ webdav.File = (*File)(nil)
 var no uint64 = 0
 
 func OpenFile(c *Client, filename string) *File {
-	ctx, span := otel.Tracer(name).Start(c.Ctx, "file open")
+	ctx, span := tracer.Start(c.Ctx, "file open")
 	span.SetAttributes(
 		attribute.String("filepath", filename),
 	)
@@ -80,7 +79,7 @@ func (f *File) Close() error {
 }
 
 func (f *File) Read(p []byte) (n int, err error) {
-	_, span := otel.Tracer(name).Start(f.Ctx, "file read")
+	_, span := tracer.Start(f.Ctx, "file read")
 	defer span.End()
 	defer err2.Handle(&err, func() {
 		if errors.Is(err, io.EOF) {
@@ -108,7 +107,7 @@ func (f *File) Read(p []byte) (n int, err error) {
 }
 
 func (f *File) Write(p []byte) (n int, err error) {
-	_, span := otel.Tracer(name).Start(f.Ctx, "file write")
+	_, span := tracer.Start(f.Ctx, "file write")
 	defer span.End()
 	defer err0.Record(&err, span)
 
@@ -127,7 +126,7 @@ func (f *File) Write(p []byte) (n int, err error) {
 }
 
 func (f *File) Seek(offset int64, whence int) (n int64, err error) {
-	_, span := otel.Tracer(name).Start(f.Ctx, "file seek")
+	_, span := tracer.Start(f.Ctx, "file seek")
 	defer span.End()
 	defer err2.Handle(&err, func() {
 		span.RecordError(err)

bash/webdav/filesystem.go

@@ -11,14 +11,13 @@ import (
 	"github.com/jellydator/ttlcache/v3"
 	. "github.com/lainio/err2/try"
 	"github.com/vscode-lcode/lcode/v2/util/err0"
-	"go.opentelemetry.io/otel"
 	"golang.org/x/net/webdav"
 )
 
 var _ webdav.FileSystem = (*Client)(nil)
 
 func (c *Client) Mkdir(ctx context.Context, name string, perm os.FileMode) (err error) {
-	_, span := otel.Tracer(name).Start(c.Ctx, "fs mkdir")
+	_, span := tracer.Start(c.Ctx, "fs mkdir")
 	defer span.End()
 	defer err0.Record(&err, span)
 
@@ -27,15 +26,15 @@ func (c *Client) Mkdir(ctx context.Context, name string, perm os.FileMode) (err
 	return
 }
 func (c *Client) OpenFile(ctx context.Context, name string, flag int, perm os.FileMode) (f webdav.File, err error) {
-	_, span := otel.Tracer(name).Start(c.Ctx, "fs openfile")
+	_, span := tracer.Start(c.Ctx, "fs openfile")
 	defer span.End()
 	defer err0.Record(&err, span)
 
 	f = OpenFile(c, name)
 	return
 }
 func (c *Client) RemoveAll(ctx context.Context, name string) (err error) {
-	_, span := otel.Tracer(name).Start(c.Ctx, "fs remove all")
+	_, span := tracer.Start(c.Ctx, "fs remove all")
 	defer span.End()
 	defer err0.Record(&err, span)
 
@@ -46,7 +45,7 @@ func (c *Client) RemoveAll(ctx context.Context, name string) (err error) {
 	return
 }
 func (c *Client) Rename(ctx context.Context, oldName, newName string) (err error) {
-	_, span := otel.Tracer(name).Start(c.Ctx, "fs rename")
+	_, span := tracer.Start(c.Ctx, "fs rename")
 	defer span.End()
 	defer err0.Record(&err, span)
 
@@ -59,7 +58,7 @@ func (c *Client) Rename(ctx context.Context, oldName, newName string) (err error
 }
 
 func (c *Client) Stat(ctx context.Context, name string) (f os.FileInfo, err error) {
-	_, span := otel.Tracer(name).Start(c.Ctx, "fs stat")
+	_, span := tracer.Start(c.Ctx, "fs stat")
 	defer span.End()
 	defer err0.Record(&err, span)