cppcheck fixes

Author: robertosfield

cmake/cppcheck-suppression-list.txt

@@ -244,6 +244,23 @@ constVariablePointer:*/src/vsg/app/SecondaryCommandGraph.cpp
 passedByValue:*/src/vsg/vk/Device.cpp
 passedByValue:*/src/vsg/vk/Instance.cpp
 
-// suppress inapproach functionStatic warnings
+// suppress inappropriate warnings
 functionStatic:*/include/vsg/io/Output.h
 functionStatic:*/include/vsg/io/Input.h
+functionStatic:*/src/vsg/app/CompileManager.h
+functionStatic:*/include/vsg/app/RecordTraversal.h
+functionStatic:*/include/vsg/io/VSG.h
+functionStatic:*/include/vsg/io/json.h
+functionStatic:*/include/vsg/io/txt.h
+functionStatic:*/include/vsg/io/tile.h
+functionStatic:*/include/vsg/state/QueryPool.h
+functionStatic:*/include/vsg/state/ArrayState.h
+functionStatic:*/include/vsg/text/StandardLayout.h
+functionStatic:*/include/vsg/utils/Builder.h
+functionStatic:*/include/vsg/utils/ShaderCompiler.h
+functionStatic:*/
+functionStatic:*/
+
+
+// suppress inappropriate warnings
+suspiciousFloatingPointCast:*/src/vsg/maths/maths_transform.cpp

include/vsg/utils/TracyInstrumentation.h

@@ -80,7 +80,7 @@ namespace vsg
         mutable std::map<ref_ptr<Device>, std::pair<tracy::VkCtx*, bool>> ctxMap;
 
     protected:
-        ~TracyContexts()
+        ~TracyContexts() override
         {
             for (auto itr = ctxMap.begin(); itr != ctxMap.end(); ++itr)
             {

src/vsg/app/Viewer.cpp

@@ -92,7 +92,7 @@ void Viewer::removeWindow(ref_ptr<Window> window)
     CommandGraphs commandGraphs;
     for (const auto& task : recordAndSubmitTasks)
     {
-        for (auto& cg : task->commandGraphs)
+        for (const auto& cg : task->commandGraphs)
         {
             if (cg->window != window) commandGraphs.push_back(cg);
         }
@@ -582,7 +582,7 @@ void Viewer::addRecordAndSubmitTaskAndPresentation(CommandGraphs commandGraphs)
     CommandGraphs combinedCommandGraphs;
     for (const auto& task : recordAndSubmitTasks)
     {
-        for (auto& cg : task->commandGraphs)
+        for (const auto& cg : task->commandGraphs)
         {
             combinedCommandGraphs.push_back(cg);
         }

src/vsg/commands/ExecuteCommands.cpp

@@ -71,7 +71,7 @@ void ExecuteCommands::record(CommandBuffer& commandBuffer) const
 
     std::scoped_lock lock(_mutex);
     std::vector<VkCommandBuffer> vk_commandBuffers;
-    for (auto& entry : _commandGraphsAndBuffers)
+    for (const auto& entry : _commandGraphsAndBuffers)
     {
         if (entry.cb) vk_commandBuffers.push_back(*entry.cb);
     }

src/vsg/state/ViewDependentState.cpp

@@ -658,7 +658,7 @@ void ViewDependentState::traverse(RecordTraversal& rt) const
         dbox eyeSpaceRegionBounds;
         for (auto& [mv, regionOfInterest] : rt.regionsOfInterest)
         {
-            for (auto& v : regionOfInterest->points)
+            for (const auto& v : regionOfInterest->points)
             {
                 eyeSpaceRegionBounds.add(mv * v);
             }

src/vsg/utils/ComputeBounds.cpp

@@ -302,7 +302,7 @@ void ComputeBounds::add(const dbox& bb)
     }
     else
     {
-        auto& matrix = matrixStack.back();
+        const auto& matrix = matrixStack.back();
         bounds.add(matrix * bb.min);
         bounds.add(matrix * dvec3(bb.max.x, bb.min.y, bb.min.z));
         bounds.add(matrix * dvec3(bb.max.x, bb.max.y, bb.min.z));
@@ -323,7 +323,7 @@ void ComputeBounds::add(const dsphere& bs)
     }
     else
     {
-        auto& matrix = matrixStack.back();
+        const auto& matrix = matrixStack.back();
         bounds.add(matrix * dvec3(bs.center.x - bs.radius, bs.center.y - bs.radius, bs.center.z - bs.radius));
         bounds.add(matrix * dvec3(bs.center.x + bs.radius, bs.center.y - bs.radius, bs.center.z - bs.radius));
         bounds.add(matrix * dvec3(bs.center.x - bs.radius, bs.center.y + bs.radius, bs.center.z - bs.radius));

src/vsg/utils/ShaderCompiler.cpp

@@ -281,7 +281,7 @@ bool ShaderCompiler::compile(ShaderStages& shaders, const std::vector<std::strin
         std::string finalShaderSource = vsg::insertIncludes(vsg_shader->module->source, options);
 
         std::vector<std::string> combinedDefines(defines);
-        for (auto& define : settings->defines) combinedDefines.push_back(define);
+        for (const auto& define : settings->defines) combinedDefines.push_back(define);
         if (!combinedDefines.empty()) finalShaderSource = combineSourceAndDefines(finalShaderSource, combinedDefines);
 
         vsg::debug("ShaderCompiler::compile() combinedDefines = ", combinedDefines);
@@ -472,8 +472,6 @@ std::string ShaderCompiler::combineSourceAndDefines(const std::string& source, c
     const std::string versionmatch = "#version";
     const std::string importdefinesmatch = "#pragma import_defines";
 
-    std::vector<std::string> finaldefines;
-
     for (std::string line; std::getline(iss, line);)
     {
         std::string sanitisedline = line;