cppcheck fixes

Author: robertosfield

include/vsg/app/CompileManager.h

@@ -91,7 +91,7 @@ namespace vsg
         std::atomic_uint failedCompileCount{0};
 
     protected:
-        ~CompileManager();
+        ~CompileManager() override;
 
         using CompileTraversals = ThreadSafeQueue<ref_ptr<CompileTraversal>>;
         size_t numCompileTraversals = 0;

include/vsg/app/CompileTraversal.h

@@ -103,7 +103,7 @@ namespace vsg
         void apply(View& view) override;
 
     protected:
-        ~CompileTraversal();
+        ~CompileTraversal() override;
 
         void add(ref_ptr<Context> context, Framebuffer& framebuffer, ref_ptr<TransferTask> transferTask, ref_ptr<View> view, const ResourceRequirements& resourceRequirements);
         void addViewDependentState(ViewDependentState& viewDependentState, ref_ptr<Device> device, ref_ptr<TransferTask> transferTask, const ResourceRequirements& resourceRequirements);

include/vsg/utils/GpuAnnotation.h

@@ -40,7 +40,7 @@ namespace vsg
         void leave(const vsg::SourceLocation* sl, uint64_t& reference, CommandBuffer& commandBuffer, const Object* object) const override;
 
     protected:
-        virtual ~GpuAnnotation();
+        ~GpuAnnotation() override;
     };
     VSG_type_name(vsg::GpuAnnotation);
 

include/vsg/utils/ShaderCompiler.h

@@ -16,7 +16,7 @@ namespace vsg
     {
     public:
         ShaderCompiler();
-        virtual ~ShaderCompiler();
+        ~ShaderCompiler() override;
 
         /// return true if shader compilation is supported by this build of VulkanSceneGraph
         /// you can also use the VSG_SUPPORTS_ShaderCompiler define provided by include/vsg/core/Version.h

include/vsg/utils/ShaderSet.h

@@ -196,7 +196,7 @@ namespace vsg
         void write(Output& output) const override;
 
     protected:
-        virtual ~ShaderSet();
+        ~ShaderSet() override;
 
         AttributeBinding _nullAttributeBinding;
         DescriptorBinding _nullDescriptorBinding;

include/vsg/utils/SharedObjects.h

@@ -73,7 +73,7 @@ namespace vsg
         void report(vsg::LogOutput& output);
 
     protected:
-        virtual ~SharedObjects();
+        ~SharedObjects() override;
 
         mutable std::recursive_mutex _mutex;
         std::map<std::type_index, ref_ptr<Object>> _defaults;

include/vsg/vk/DeviceMemory.h

@@ -98,7 +98,7 @@ namespace vsg
         }
 
         template<typename... Args>
-        static ref_ptr<MappedData> create(DeviceMemory* deviceMemory, VkDeviceSize offset, VkMemoryMapFlags flags, Data::Properties properties, Args... args)
+        static ref_ptr<MappedData> create(DeviceMemory* deviceMemory, VkDeviceSize offset, VkMemoryMapFlags flags, const Data::Properties& properties, Args... args)
         {
             auto data = ref_ptr<MappedData>(new MappedData(deviceMemory, offset, flags, args...));
             data->properties = properties;