cppcheck suggest change

robertosfield · robertosfield · commit 4d57d60d2daa · 2026-05-09T13:33:00.000+01:00
diff --git a/include/vsg/app/WindowResizeHandler.h b/include/vsg/app/WindowResizeHandler.h
@@ -53,7 +53,7 @@ namespace vsg
         WindowResizeHandler();
 
         template<typename T, typename R>
-        T scale_parameter(T original, R extentOriginal, R extentNew)
+        static T scale_parameter(T original, R extentOriginal, R extentNew)
         {
             if (original == static_cast<T>(extentOriginal)) return static_cast<T>(extentNew);
             return static_cast<T>(static_cast<float>(original) * static_cast<float>(extentNew) / static_cast<float>(extentOriginal) + 0.5f);

Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,7 @@ namespace vsg`
`53`	`53`	`WindowResizeHandler();`
`54`	`54`
`55`	`55`	`template<typename T, typename R>`
`56`		`- T scale_parameter(T original, R extentOriginal, R extentNew)`
	`56`	`+ static T scale_parameter(T original, R extentOriginal, R extentNew)`
`57`	`57`	`{`
`58`	`58`	`if (original == static_cast<T>(extentOriginal)) return static_cast<T>(extentNew);`
`59`	`59`	`return static_cast<T>(static_cast<float>(original) * static_cast<float>(extentNew) / static_cast<float>(extentOriginal) + 0.5f);`